Skip to content

Commit 54dfdee

Browse files
committed
🐛 Envtest: Do not pull in ginkgo outside of _test.go files
1 parent c14d8e6 commit 54dfdee

21 files changed

+40
-30
lines changed

pkg/builder/builder_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"k8s.io/apimachinery/pkg/runtime/schema"
2929
"k8s.io/client-go/rest"
3030
"sigs.k8s.io/controller-runtime/pkg/envtest"
31+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
3132
"sigs.k8s.io/controller-runtime/pkg/internal/testing/integration/addr"
3233
logf "sigs.k8s.io/controller-runtime/pkg/log"
3334
"sigs.k8s.io/controller-runtime/pkg/log/zap"
@@ -37,7 +38,7 @@ import (
3738

3839
func TestBuilder(t *testing.T) {
3940
RegisterFailHandler(Fail)
40-
RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{envtest.NewlineReporter{}})
41+
RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{printer.NewlineReporter{}})
4142
}
4243

4344
var testenv *envtest.Environment

pkg/cache/cache_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,14 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728
logf "sigs.k8s.io/controller-runtime/pkg/log"
2829
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2930
)
3031

3132
func TestSource(t *testing.T) {
3233
RegisterFailHandler(Fail)
33-
RunSpecsWithDefaultAndCustomReporters(t, "Cache Suite", []Reporter{envtest.NewlineReporter{}})
34+
RunSpecsWithDefaultAndCustomReporters(t, "Cache Suite", []Reporter{printer.NewlineReporter{}})
3435
}
3536

3637
var testenv *envtest.Environment

pkg/client/apiutil/apiutil_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ import (
2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
2424
"k8s.io/client-go/rest"
25-
"sigs.k8s.io/controller-runtime/pkg/envtest"
25+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2626

2727
logf "sigs.k8s.io/controller-runtime/pkg/log"
2828
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2929
)
3030

3131
func TestSource(t *testing.T) {
3232
RegisterFailHandler(Fail)
33-
RunSpecsWithDefaultAndCustomReporters(t, "API Utilities Test Suite", []Reporter{envtest.NewlineReporter{}})
33+
RunSpecsWithDefaultAndCustomReporters(t, "API Utilities Test Suite", []Reporter{printer.NewlineReporter{}})
3434
}
3535

3636
var cfg *rest.Config

pkg/client/client_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728

2829
logf "sigs.k8s.io/controller-runtime/pkg/log"
2930
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3031
)
3132

3233
func TestSource(t *testing.T) {
3334
RegisterFailHandler(Fail)
34-
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{envtest.NewlineReporter{}})
35+
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}})
3536
}
3637

3738
var testenv *envtest.Environment

pkg/client/fake/client_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,15 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525

2626
logf "sigs.k8s.io/controller-runtime/pkg/log"
2727
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2828
)
2929

3030
func TestSource(t *testing.T) {
3131
RegisterFailHandler(Fail)
32-
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{envtest.NewlineReporter{}})
32+
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}})
3333
}
3434

3535
var _ = BeforeSuite(func(done Done) {

pkg/controller/controller_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728
logf "sigs.k8s.io/controller-runtime/pkg/log"
2829
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2930
"sigs.k8s.io/controller-runtime/pkg/metrics"
3031
)
3132

3233
func TestSource(t *testing.T) {
3334
RegisterFailHandler(Fail)
34-
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{envtest.NewlineReporter{}})
35+
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}})
3536
}
3637

3738
var testenv *envtest.Environment
File renamed without changes.

pkg/handler/eventhandler_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,14 @@ import (
2323
. "github.com/onsi/gomega"
2424
"k8s.io/client-go/rest"
2525
"sigs.k8s.io/controller-runtime/pkg/envtest"
26+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2627
logf "sigs.k8s.io/controller-runtime/pkg/log"
2728
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2829
)
2930

3031
func TestEventhandler(t *testing.T) {
3132
RegisterFailHandler(Fail)
32-
RunSpecsWithDefaultAndCustomReporters(t, "Eventhandler Suite", []Reporter{envtest.NewlineReporter{}})
33+
RunSpecsWithDefaultAndCustomReporters(t, "Eventhandler Suite", []Reporter{printer.NewlineReporter{}})
3334
}
3435

3536
var testenv *envtest.Environment

pkg/healthz/healthz_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
logf "sigs.k8s.io/controller-runtime/pkg/log"
2626
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2727
)
2828

2929
func TestHealthz(t *testing.T) {
3030
RegisterFailHandler(Fail)
31-
RunSpecsWithDefaultAndCustomReporters(t, "Healthz Suite", []Reporter{envtest.NewlineReporter{}})
31+
RunSpecsWithDefaultAndCustomReporters(t, "Healthz Suite", []Reporter{printer.NewlineReporter{}})
3232
}
3333

3434
var _ = BeforeSuite(func() {

pkg/internal/controller/controller_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,14 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728
logf "sigs.k8s.io/controller-runtime/pkg/log"
2829
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2930
)
3031

3132
func TestSource(t *testing.T) {
3233
RegisterFailHandler(Fail)
33-
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{envtest.NewlineReporter{}})
34+
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}})
3435
}
3536

3637
var testenv *envtest.Environment

pkg/internal/recorder/recorder_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,14 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728
logf "sigs.k8s.io/controller-runtime/pkg/log"
2829
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2930
)
3031

3132
func TestRecorder(t *testing.T) {
3233
RegisterFailHandler(Fail)
33-
RunSpecsWithDefaultAndCustomReporters(t, "Recorder Integration Suite", []Reporter{envtest.NewlineReporter{}})
34+
RunSpecsWithDefaultAndCustomReporters(t, "Recorder Integration Suite", []Reporter{printer.NewlineReporter{}})
3435
}
3536

3637
var testenv *envtest.Environment

pkg/manager/manager_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@ import (
2424
"k8s.io/client-go/kubernetes"
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/envtest"
27+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2728
logf "sigs.k8s.io/controller-runtime/pkg/log"
2829
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2930
"sigs.k8s.io/controller-runtime/pkg/metrics"
3031
)
3132

3233
func TestSource(t *testing.T) {
3334
RegisterFailHandler(Fail)
34-
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{envtest.NewlineReporter{}})
35+
RunSpecsWithDefaultAndCustomReporters(t, "Controller Integration Suite", []Reporter{printer.NewlineReporter{}})
3536
}
3637

3738
var testenv *envtest.Environment

pkg/manager/signals/signals_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ import (
2222

2323
. "github.com/onsi/ginkgo"
2424
. "github.com/onsi/gomega"
25-
"sigs.k8s.io/controller-runtime/pkg/envtest"
25+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2626
)
2727

2828
func TestSource(t *testing.T) {
2929
RegisterFailHandler(Fail)
30-
RunSpecsWithDefaultAndCustomReporters(t, "Runtime Signal Suite", []Reporter{envtest.NewlineReporter{}})
30+
RunSpecsWithDefaultAndCustomReporters(t, "Runtime Signal Suite", []Reporter{printer.NewlineReporter{}})
3131
}
3232

3333
var _ = BeforeSuite(func() {

pkg/predicate/predicate_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
logf "sigs.k8s.io/controller-runtime/pkg/log"
2626
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2727
)
2828

2929
func TestPredicate(t *testing.T) {
3030
RegisterFailHandler(Fail)
31-
RunSpecsWithDefaultAndCustomReporters(t, "Predicate Suite", []Reporter{envtest.NewlineReporter{}})
31+
RunSpecsWithDefaultAndCustomReporters(t, "Predicate Suite", []Reporter{printer.NewlineReporter{}})
3232
}
3333

3434
var _ = BeforeSuite(func() {

pkg/reconcile/reconcile_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
logf "sigs.k8s.io/controller-runtime/pkg/log"
2626
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2727
)
2828

2929
func TestReconcile(t *testing.T) {
3030
RegisterFailHandler(Fail)
31-
RunSpecsWithDefaultAndCustomReporters(t, "reconcile Suite", []Reporter{envtest.NewlineReporter{}})
31+
RunSpecsWithDefaultAndCustomReporters(t, "reconcile Suite", []Reporter{printer.NewlineReporter{}})
3232
}
3333

3434
var _ = BeforeSuite(func() {

pkg/runtime/inject/inject_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
)
2626

2727
func TestSource(t *testing.T) {
2828
RegisterFailHandler(Fail)
29-
RunSpecsWithDefaultAndCustomReporters(t, "Runtime Injection Suite", []Reporter{envtest.NewlineReporter{}})
29+
RunSpecsWithDefaultAndCustomReporters(t, "Runtime Injection Suite", []Reporter{printer.NewlineReporter{}})
3030
}

pkg/source/internal/internal_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121

2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
logf "sigs.k8s.io/controller-runtime/pkg/log"
2626
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2727
)
2828

2929
func TestInternal(t *testing.T) {
3030
RegisterFailHandler(Fail)
31-
RunSpecsWithDefaultAndCustomReporters(t, "Internal Suite", []Reporter{envtest.NewlineReporter{}})
31+
RunSpecsWithDefaultAndCustomReporters(t, "Internal Suite", []Reporter{printer.NewlineReporter{}})
3232
}
3333

3434
var _ = BeforeSuite(func() {

pkg/source/source_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ import (
2525
"k8s.io/client-go/rest"
2626
"sigs.k8s.io/controller-runtime/pkg/cache"
2727
"sigs.k8s.io/controller-runtime/pkg/envtest"
28+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2829
logf "sigs.k8s.io/controller-runtime/pkg/log"
2930
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3031
)
3132

3233
func TestSource(t *testing.T) {
3334
RegisterFailHandler(Fail)
34-
RunSpecsWithDefaultAndCustomReporters(t, "Source Suite", []Reporter{envtest.NewlineReporter{}})
35+
RunSpecsWithDefaultAndCustomReporters(t, "Source Suite", []Reporter{printer.NewlineReporter{}})
3536
}
3637

3738
var testenv *envtest.Environment

pkg/webhook/admission/admission_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ import (
2222
. "github.com/onsi/ginkgo"
2323
. "github.com/onsi/gomega"
2424

25-
"sigs.k8s.io/controller-runtime/pkg/envtest"
25+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2626
logf "sigs.k8s.io/controller-runtime/pkg/log"
2727
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2828
)
2929

3030
func TestAdmissionWebhook(t *testing.T) {
3131
RegisterFailHandler(Fail)
32-
RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{envtest.NewlineReporter{}})
32+
RunSpecsWithDefaultAndCustomReporters(t, "application Suite", []Reporter{printer.NewlineReporter{}})
3333
}
3434

3535
var _ = BeforeSuite(func(done Done) {

pkg/webhook/conversion/conversion_suite_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121
. "github.com/onsi/ginkgo"
2222
. "github.com/onsi/gomega"
2323

24-
"sigs.k8s.io/controller-runtime/pkg/envtest"
24+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2525
logf "sigs.k8s.io/controller-runtime/pkg/log"
2626
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2727
)
2828

2929
func TestConversionWebhook(t *testing.T) {
3030
RegisterFailHandler(Fail)
31-
RunSpecsWithDefaultAndCustomReporters(t, "CRD conversion Suite", []Reporter{envtest.NewlineReporter{}})
31+
RunSpecsWithDefaultAndCustomReporters(t, "CRD conversion Suite", []Reporter{printer.NewlineReporter{}})
3232
}
3333

3434
var _ = BeforeSuite(func(done Done) {

pkg/webhook/webhook_suite_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ import (
2525
"k8s.io/client-go/kubernetes"
2626
"k8s.io/client-go/rest"
2727
"sigs.k8s.io/controller-runtime/pkg/envtest"
28+
"sigs.k8s.io/controller-runtime/pkg/envtest/printer"
2829
logf "sigs.k8s.io/controller-runtime/pkg/log"
2930
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3031
)
3132

3233
func TestSource(t *testing.T) {
3334
RegisterFailHandler(Fail)
34-
RunSpecsWithDefaultAndCustomReporters(t, "Webhook Integration Suite", []Reporter{envtest.NewlineReporter{}})
35+
RunSpecsWithDefaultAndCustomReporters(t, "Webhook Integration Suite", []Reporter{printer.NewlineReporter{}})
3536
}
3637

3738
var testenv *envtest.Environment

0 commit comments

Comments
 (0)