From 72bcb6c7810004136e25f276cccddfaf7af5018c Mon Sep 17 00:00:00 2001 From: fisker Date: Fri, 16 May 2025 23:10:38 +0800 Subject: [PATCH 1/3] Add `sideEffects: false` to `libesm/package.json` --- package.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 7b18eb1f..9be90677 100644 --- a/package.json +++ b/package.json @@ -71,8 +71,8 @@ "clean": "rm -rf libcsm/ libesm/ dist/ coverage/ .nyc_output/", "lint": "yarn eslint", "build": "yarn lint && yarn generate-esm && yarn generate-cjs && yarn check-types && yarn run-rollup && yarn run-uglify", - "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo '{\"type\": \"commonjs\"}' > libcjs/package.json", - "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo '{\"type\": \"module\"}' > libesm/package.json", + "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo {\"type\": \"commonjs\"} > libcjs/package.json", + "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo {\"type\": \"module\",\"sideEffects\":false} > libesm/package.json", "check-types": "yarn run-tsd && yarn run-attw", "test": "nyc yarn _test", "_test": "yarn build && cross-env NODE_ENV=test yarn run-mocha", @@ -127,5 +127,6 @@ "lines": 100, "functions": 100, "statements": 100 - } + }, + "sideEffects": false } From 5b7948c2c6e7775515826c0038f4f3b8b2c52e00 Mon Sep 17 00:00:00 2001 From: Mark Amery Date: Mon, 19 May 2025 12:38:38 +0100 Subject: [PATCH 2/3] Make tweaks I proposed in convo at https://github.com/kpdecker/jsdiff/pull/612 --- package.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 9be90677..0dc62e63 100644 --- a/package.json +++ b/package.json @@ -71,8 +71,8 @@ "clean": "rm -rf libcsm/ libesm/ dist/ coverage/ .nyc_output/", "lint": "yarn eslint", "build": "yarn lint && yarn generate-esm && yarn generate-cjs && yarn check-types && yarn run-rollup && yarn run-uglify", - "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo {\"type\": \"commonjs\"} > libcjs/package.json", - "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo {\"type\": \"module\",\"sideEffects\":false} > libesm/package.json", + "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo {\"type\": \"commonjs\", \"sideEffects\":false} > libcjs/package.json", + "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo {\"type\": \"module\", \"sideEffects\":false} > libesm/package.json", "check-types": "yarn run-tsd && yarn run-attw", "test": "nyc yarn _test", "_test": "yarn build && cross-env NODE_ENV=test yarn run-mocha", @@ -127,6 +127,5 @@ "lines": 100, "functions": 100, "statements": 100 - }, - "sideEffects": false + } } From 27e04ed662eef6ed69bcebf23d635bb0c0c6ef61 Mon Sep 17 00:00:00 2001 From: Mark Amery Date: Mon, 19 May 2025 12:57:46 +0100 Subject: [PATCH 3/3] Fix build for Unix (and break it again for Windows in the process) --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 0dc62e63..ae6a3d25 100644 --- a/package.json +++ b/package.json @@ -71,8 +71,8 @@ "clean": "rm -rf libcsm/ libesm/ dist/ coverage/ .nyc_output/", "lint": "yarn eslint", "build": "yarn lint && yarn generate-esm && yarn generate-cjs && yarn check-types && yarn run-rollup && yarn run-uglify", - "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo {\"type\": \"commonjs\", \"sideEffects\":false} > libcjs/package.json", - "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo {\"type\": \"module\", \"sideEffects\":false} > libesm/package.json", + "generate-cjs": "yarn tsc --module commonjs --outDir libcjs && echo '{\"type\": \"commonjs\", \"sideEffects\":false}' > libcjs/package.json", + "generate-esm": "yarn tsc --module nodenext --outDir libesm && echo '{\"type\": \"module\", \"sideEffects\":false}' > libesm/package.json", "check-types": "yarn run-tsd && yarn run-attw", "test": "nyc yarn _test", "_test": "yarn build && cross-env NODE_ENV=test yarn run-mocha",