Both readlink args should not point to the same buffer

David Carlier · nikic · commit e1e63b89f41d · 2019-04-15T15:55:00.000+02:00
diff --git a/Zend/zend_gdb.c b/Zend/zend_gdb.c
@@ -123,9 +123,10 @@ ZEND_API int zend_gdb_present(void)
 				}
 				pid = atoi(s);
 				if (pid) {
+					char out[1024];
 					sprintf(buf, "/proc/%d/exe", (int)pid);
-					if (readlink(buf, buf, sizeof(buf) - 1) > 0) {
-						if (strstr(buf, "gdb")) {
+					if (readlink(buf, out, sizeof(out) - 1) > 0) {
+						if (strstr(out, "gdb")) {
 							ret = 1;
 						}
 					}

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,10 @@ ZEND_API int zend_gdb_present(void)`
`123`	`123`	`}`
`124`	`124`	`pid = atoi(s);`
`125`	`125`	`if (pid) {`
	`126`	`+ char out[1024];`
`126`	`127`	`sprintf(buf, "/proc/%d/exe", (int)pid);`
`127`		`- if (readlink(buf, buf, sizeof(buf) - 1) > 0) {`
`128`		`- if (strstr(buf, "gdb")) {`
	`128`	`+ if (readlink(buf, out, sizeof(out) - 1) > 0) {`
	`129`	`+ if (strstr(out, "gdb")) {`
`129`	`130`	`ret = 1;`
`130`	`131`	`}`
`131`	`132`	`}`