Skip to content

Commit 62ed521

Browse files
committed
Fix function redefinition warnings in test_similarities.jl.
Remove warnings that arise from redefining functions by replacing the use of single-line functions (e.g. f(x) = x) with anonymous functions (e.g. f = x -> x).
1 parent a76d5e0 commit 62ed521

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

test/test_similarities.jl

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -88,57 +88,57 @@ end
8888

8989
@testset "Compute L^1 distance and norm" begin
9090
interval = LSHFunctions.@interval(-π x π)
91-
f(x) = 0
92-
g(x) = 2
91+
f = x -> 0
92+
g = x -> 2
9393

9494
@test L1_norm(g, interval) L1(f, g, interval) 4π
9595

96-
g(x) = x
96+
g = x -> x
9797

9898
@test L1_norm(g, interval) L1(f, g, interval) π^2
9999

100-
f(x) = x
101-
g(x) = 2x.^2
100+
f = x -> x
101+
g = x -> 2x.^2
102102

103103
@test L1(f, g, interval) L1_norm(x -> f(x) - g(x), interval)
104104
@test L1(f, g, interval) quadgk(x -> abs(f(x) - g(x)), -π, π)[1]
105105
end
106106

107107
@testset "Compute L^2 distance and norm" begin
108108
interval = LSHFunctions.@interval(-π x π)
109-
f(x) = 0
110-
g(x) = 2
109+
f = x -> 0
110+
g = x -> 2
111111

112112
@test L2_norm(g, interval) L2(f, g, interval) (8π)
113113

114-
g(x) = x
114+
g = x -> x
115115

116116
@test L2_norm(g, interval) L2(f, g, interval) (2π^3 / 3)
117117

118-
f(x) = x
119-
g(x) = 2x.^2
118+
f = x -> x
119+
g = x -> 2x.^2
120120

121121
@test L2(f, g, interval) L2_norm(x -> f(x) - g(x), interval)
122122
@test L2(f, g, interval) quadgk(x -> abs2(f(x) - g(x)), -π, π)[1]
123123
end
124124

125125
@testset "Compute L^p distance and norm" begin
126126
interval = LSHFunctions.@interval(-π x π)
127-
f(x) = 0
128-
g(x) = 2
127+
f = x -> 0
128+
g = x -> 2
129129

130130
@test Lp_norm(g, interval, 1) Lp(f, g, interval, 1) L1(f, g, interval)
131131
@test Lp_norm(g, interval, 2) Lp(f, g, interval, 2) L2(f, g, interval)
132132
@test Lp_norm(g, interval, 3) Lp(f, g, interval, 3) (16π)^(1/3)
133133

134-
g(x) = x
134+
g = x -> x
135135

136136
@test Lp_norm(g, interval, 1) Lp(f, g, interval, 1) L1(f, g, interval)
137137
@test Lp_norm(g, interval, 2) Lp(f, g, interval, 2) L2(f, g, interval)
138138
@test Lp_norm(g, interval, 3) Lp(f, g, interval, 3) ^4/2)^(1/3)
139139

140-
f(x) = x
141-
g(x) = 2x.^2
140+
f = x -> x
141+
g = x -> 2x.^2
142142
p = rand() + 1
143143

144144
@test Lp(f, g, interval, p) Lp_norm(x -> f(x) - g(x), interval, p)
@@ -172,8 +172,8 @@ end
172172

173173
@testset "Compute cosine similarity between functions" begin
174174
interval = LSHFunctions.@interval(0 x 1)
175-
f(x) = (x 0.5) ? 1.0 : 0.0
176-
g(x) = (x 0.5) ? 0.0 : 1.0
175+
f = x -> (x 0.5) ? 1.0 : 0.0
176+
g = x -> (x 0.5) ? 0.0 : 1.0
177177

178178
@test cossim(f, g, interval) 0
179179
@test cossim(f, f, interval) cossim(g, g, interval) 1
@@ -183,8 +183,8 @@ end
183183
cossim(g, x -> -g(x), interval) -1
184184
@test_throws ErrorException cossim(f, x -> 0.0, interval)
185185

186-
f(x) = x
187-
g(x) = x.^2
186+
f = x -> x
187+
g = x -> x.^2
188188

189189
@test L2_norm(f, interval) 1/√3
190190
@test L2_norm(g, interval) 1/√5
@@ -310,15 +310,15 @@ end
310310

311311
@testset "Compute L^2 inner products between pairs of functions" begin
312312
interval = LSHFunctions.@interval(-π x π)
313-
f(x) = 1
314-
g(x) = x
313+
f = x -> 1
314+
g = x -> x
315315

316316
@test inner_prod(f, f, interval) L2_norm(f, interval)^2 2π
317317
@test inner_prod(g, g, interval) L2_norm(g, interval)^2 2π^3 / 3
318318
@test isapprox(inner_prod(f, g, interval), 0.0; atol = 1e-15)
319319

320-
f(x) = sin(x)
321-
g(x) = cos(x)
320+
f = x -> sin(x)
321+
g = x -> cos(x)
322322

323323
@test inner_prod(f, f, interval) L2_norm(f, interval)^2
324324
quadgk(x -> sin(x)^2, -π, π)[1]

0 commit comments

Comments
 (0)