Fix error msg, Compiler Warning

Time out recover was generating a confusing error message when DEBUG level was set, Clarify meaning.  Thanks to @valki2

When Arduino 1.8.5 configured for maximum compiler warning, my sloppy code generates multiple errors. :grimace:  Thanks @PicoEmma
I fixed most of the warnings, but I haven't figure out how to clear one type of them.  I use a structure to decode a peripheral memory register, the compiler reports it as an:
>
C:\Users\e\Documents\Arduino\hardware\espressif\esp32\cores\esp32\esp32-hal-i2c.c: In function 'dumpCmdQueue':
C:\Users\e\Documents\Arduino\hardware\espressif\esp32\cores\esp32\esp32-hal-i2c.c:399:17: warning: variable 'c' set but not used [-Wunused-but-set-variable]
   I2C_COMMAND_t c;
                 ^

Chuck.

Author: stickbreaker

cores/esp32/esp32-hal-i2c.c

@@ -64,16 +64,16 @@ enum {
 #define I2C_MUTEX_UNLOCK()
 
 static i2c_t _i2c_bus_array[2] = {
-    {(volatile i2c_dev_t *)(DR_REG_I2C_EXT_BASE_FIXED), 0,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0},
-    {(volatile i2c_dev_t *)(DR_REG_I2C1_EXT_BASE_FIXED), 1,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0}
+    {(volatile i2c_dev_t *)(DR_REG_I2C_EXT_BASE_FIXED), 0,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0,0},
+    {(volatile i2c_dev_t *)(DR_REG_I2C1_EXT_BASE_FIXED), 1,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0,0}
 };
 #else
 #define I2C_MUTEX_LOCK()    do {} while (xSemaphoreTake(i2c->lock, portMAX_DELAY) != pdPASS)
 #define I2C_MUTEX_UNLOCK()  xSemaphoreGive(i2c->lock)
 
 static i2c_t _i2c_bus_array[2] = {
-    {(volatile i2c_dev_t *)(DR_REG_I2C_EXT_BASE_FIXED), NULL, 0,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0},
-    {(volatile i2c_dev_t *)(DR_REG_I2C1_EXT_BASE_FIXED), NULL, 1,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0}
+    {(volatile i2c_dev_t *)(DR_REG_I2C_EXT_BASE_FIXED), NULL, 0,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0,0},
+    {(volatile i2c_dev_t *)(DR_REG_I2C1_EXT_BASE_FIXED), NULL, 1,I2C_NONE,I2C_NONE,I2C_ERROR_OK,NULL,NULL,NULL,0,0,0,0}
 };
 #endif
 
@@ -628,7 +628,17 @@ log_n("Enable Core Debug Level \"Error\"");
 
 void i2cDumpI2c(i2c_t * i2c){
 log_e("i2c=%p",i2c);
-log_e("dev=%p date=%p",i2c->dev,i2c->dev->date);
+char levelText[8];
+switch(ARDUHAL_LOG_LEVEL){
+  case 0 : levelText = sprintf("NONE"); break;
+  case 1 : levelText = sprintf("ERROR"); break;
+  case 2 : levelText = sprintf("WARN"); break;
+  case 3 : levelText = sprintf("INFO"); break;
+  case 4 : levelText = sprintf("DEBUG"); break;
+  case 5 : levelText = sprintf("VERBOSE"); break;
+    default : levelText = sprintf("uk=%d",ARDUHAL_LOG_LEVEL);
+}
+log_e("dev=%p date=%p level=%s",i2c->dev,i2c->dev->date,levelText);
 #if !CONFIG_DISABLE_HAL_LOCKS
 log_e("lock=%p",i2c->lock);
 #endif
@@ -820,12 +830,13 @@ static void IRAM_ATTR i2c_isr_handler_default(void* arg){
 i2c_t* p_i2c = (i2c_t*) arg; // recover data
 uint32_t activeInt = p_i2c->dev->int_status.val&0x1FFF;
 
-portBASE_TYPE HPTaskAwoken = pdFALSE,xResult; 
+portBASE_TYPE HPTaskAwoken = pdFALSE; 
 
 if(p_i2c->stage==I2C_DONE){ //get Out
   log_e("eject int=%p, ena=%p",activeInt,p_i2c->dev->int_ena.val);
   p_i2c->dev->int_ena.val = 0;
   p_i2c->dev->int_clr.val = activeInt; //0x1FFF;
+  
   return;
   }
 while (activeInt != 0) { // Ordering of 'if(activeInt)' statements is important, don't change
@@ -843,8 +854,7 @@ while (activeInt != 0) { // Ordering of 'if(activeInt)' statements is important,
   intBuff[intPos[p_i2c->num]][2][p_i2c->num] = xTaskGetTickCountFromISR(); // when IRQ fired
 
 #endif
-  uint32_t oldInt =activeInt;
-
+ 
   if (activeInt & I2C_TRANS_START_INT_ST_M) {
  //   p_i2c->byteCnt=0;
     if(p_i2c->stage==I2C_STARTUP){
@@ -1017,6 +1027,7 @@ if(!i2c->i2c_event){
   }
 if(i2c->i2c_event) {
   uint32_t ret=xEventGroupClearBits(i2c->i2c_event, 0xFF);
+  if(ret != ESP_OK) log_e("Unable to Clear Event Bits=%d",ret);
   }
 else {// failed to create EventGroup
   log_e("eventCreate failed=%p",i2c->i2c_event);
@@ -1094,7 +1105,7 @@ i2c->dev->int_ena.val =
 
 if(!i2c->intr_handle){ // create ISR for either peripheral 
  // log_i("create ISR %d",i2c->num);
-  uint32_t ret;
+  uint32_t ret=0xFFFFFFFF; // clear uninitialized var warning
   switch(i2c->num){
     case 0:
       ret = esp_intr_alloc(ETS_I2C_EXT0_INTR_SOURCE, 0, &i2c_isr_handler_default, i2c, &i2c->intr_handle);
@@ -1153,7 +1164,7 @@ if(eBits&EVENT_DONE){ // no gross timeout
   uint32_t expected =(totalBytes*10*1000)/i2cGetFrequency(i2c);
   if((tAfter-tBefore)>(expected+1)) { //used some of the timeout Period
     // expected can be zero due to small packets
-    log_e("TimeoutRecovery: expected=%ums, actual=%ums",expected,(tAfter-tBefore));
+    log_d("used TimeoutRecovery: expected=%ums, actual=%ums, configured=%ums ",expected,(tAfter-tBefore),timeOutMillis);
     i2cDumpI2c(i2c);
     i2cDumpInts(i2c->num);
     }
@@ -1242,7 +1253,7 @@ void i2cReleaseISR(i2c_t * i2c){
 if(i2c->intr_handle){
 //  log_i("Release ISR %d",i2c->num);
   esp_err_t error =esp_intr_free(i2c->intr_handle);
-//  log_e("released ISR=%d",error);
+  if(error!=ESP_OK) log_e("Error releasing ISR=%d",error);
   i2c->intr_handle=NULL;
   }
 }