collect passing success as well

Author: ShMcK

src/services/testRunner/parser.test.ts

@@ -6,15 +6,20 @@ describe('parser', () => {
 1..1
 ok 1 - Should pass
 `
-    expect(parser(example)).toEqual({ ok: true, fails: [] })
+    expect(parser(example)).toEqual({ ok: true, passed: [{ message: 'Should pass' }], failed: [] })
   })
   test('should detect multiple successes', () => {
     const example = `
 1..2
 ok 1 - Should pass
 ok 2 - Should also pass
 `
-    expect(parser(example)).toEqual({ ok: true, fails: [] })
+    const result = parser(example)
+    expect(result).toEqual({
+      ok: true,
+      passed: [{ message: 'Should pass' }, { message: 'Should also pass' }],
+      failed: [],
+    })
   })
   test('should detect failure if no tests passed', () => {
     const example = `
@@ -44,7 +49,7 @@ not ok 2 - First to fail
 ok 3 - Also passes
 not ok 4 - Second to fail
 `
-    expect(parser(example).fails).toEqual([{ message: 'First to fail' }, { message: 'Second to fail' }])
+    expect(parser(example).failed).toEqual([{ message: 'First to fail' }, { message: 'Second to fail' }])
   })
 
   test('should parse mocha tap example', () => {
@@ -72,7 +77,7 @@ ok 3 sumItems should total numbers accurately
 # fail 1
 # skip 0
 `
-    expect(parser(example).fails).toEqual([{ message: "sumItems shouldn't return NaN" }])
+    expect(parser(example).failed).toEqual([{ message: "sumItems shouldn't return NaN" }])
   })
   test('should capture single error details', () => {
     const example = `
@@ -86,8 +91,8 @@ not ok 1 package.json should have a valid "author" key
 # skip 0
 `
     const result = parser(example)
-    expect(result.fails[0].message).toBe('package.json should have a valid "author" key')
-    expect(result.fails[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
+    expect(result.failed[0].message).toBe('package.json should have a valid "author" key')
+    expect(result.failed[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
 at Context.<anonymous> (test/packagejson.test.js:11:12)
 at processImmediate (internal/timers.js:439:21)`)
   })
@@ -105,12 +110,12 @@ not ok 2 package.json should have a valid "description" key
 # skip 0
 `
     const result = parser(example)
-    expect(result.fails[0].message).toBe('package.json should have a valid "author" key')
-    expect(result.fails[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
+    expect(result.failed[0].message).toBe('package.json should have a valid "author" key')
+    expect(result.failed[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
 at Context.<anonymous> (test/packagejson.test.js:11:12)
 at processImmediate (internal/timers.js:439:21)`)
-    expect(result.fails[1].message).toBe('package.json should have a valid "description" key')
-    expect(result.fails[1].details).toBe(`AssertionError [ERR_ASSERTION]: no "description" key provided`)
+    expect(result.failed[1].message).toBe('package.json should have a valid "description" key')
+    expect(result.failed[1].details).toBe(`AssertionError [ERR_ASSERTION]: no "description" key provided`)
   })
   test('should capture multiple error details between successes', () => {
     const example = `
@@ -129,11 +134,11 @@ ok 5 some passing test
 # skip 0
 `
     const result = parser(example)
-    expect(result.fails[0].message).toBe('package.json should have a valid "author" key')
-    expect(result.fails[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
+    expect(result.failed[0].message).toBe('package.json should have a valid "author" key')
+    expect(result.failed[0].details).toBe(`AssertionError [ERR_ASSERTION]: no "author" key provided
 at Context.<anonymous> (test/packagejson.test.js:11:12)
 at processImmediate (internal/timers.js:439:21)`)
-    expect(result.fails[1].message).toBe('package.json should have a valid "description" key')
-    expect(result.fails[1].details).toBe(`AssertionError [ERR_ASSERTION]: no "description" key provided`)
+    expect(result.failed[1].message).toBe('package.json should have a valid "description" key')
+    expect(result.failed[1].details).toBe(`AssertionError [ERR_ASSERTION]: no "description" key provided`)
   })
 })

src/services/testRunner/parser.ts

@@ -1,11 +1,12 @@
 interface ParserOutput {
   ok: boolean
-  fails: Array<{ message: string; details?: string }>
+  passed: Array<{ message: string }>
+  failed: Array<{ message: string; details?: string }>
 }
 
 const r = {
   fail: /^not ok \d+\s(\-\s)?(.+)+$/,
-  pass: /^ok/,
+  pass: /^ok \d+\s(\-\s)?(.+)+$/,
   details: /^#\s{2}(.+)$/,
 }
 
@@ -15,17 +16,18 @@ const parser = (text: string): ParserOutput => {
   const lines = text.split('\n')
 
   const result: ParserOutput = {
-    ok: false,
-    fails: [],
+    ok: true,
+    passed: [],
+    failed: [],
   }
 
   // temporary holder of error detail strings
   let currentDetails: string | null = null
 
   const addCurrentDetails = () => {
-    const failLength: number = result.fails.length
+    const failLength: number = result.failed.length
     if (currentDetails && !!failLength) {
-      result.fails[failLength - 1].details = currentDetails
+      result.failed[failLength - 1].details = currentDetails
       currentDetails = null
     }
   }
@@ -35,20 +37,19 @@ const parser = (text: string): ParserOutput => {
       continue
     }
     // be optimistic! check for success
-    if (!result.ok && !result.fails.length) {
-      if (!!detect('pass', line)) {
-        result.ok = true
-        addCurrentDetails()
-        continue
-      }
+    const isPass = detect('pass', line)
+    if (!!isPass) {
+      result.passed.push({ message: isPass[2].trim() })
+      addCurrentDetails()
+      continue
     }
 
     // check for failure
     const isFail = detect('fail', line)
     if (!!isFail) {
       result.ok = false
       addCurrentDetails()
-      result.fails.push({ message: isFail[2] })
+      result.failed.push({ message: isFail[2].trim() })
       continue
     }