-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic pattern breaks chainability #18
Comments
Let's explore if we can come up with a cleaner way of handling this. @zenorocha what do you think about the lightweight start in this repo? Is it different enough from the jQuery boilerplate for us to continue keeping in place or should we try to refactor it further? |
They are very similar, so I think it's better to refactor or remove the lightweight start from here and maintain the other one. Since you already made a reference for jQuery Boilerplate in README I think that will not be a problem. |
I agree with removing it. Do you think it's worth documenting the jQuery Boilerplate better in the chapter in my book as a replacement to the lightweight start too? It might help get a few more folks looking at it as well. |
Yeah, that would be nice! |
@zenorocha how should we do this? submodule the main boilerplate or just link to it from the readme? |
Just link, since the boilerplate repository has a different structure of patterns repository. |
Yap, i agree with @zenorocha, providing just a link in the README seems to be the most logical way. |
Is it a good practice to break the second plugin instance if we call it like this?
It will not work since we allow the plugin only to be instantiated once per element. But to remove the if statement in our plugin definition is even not the best idea, or?
The text was updated successfully, but these errors were encountered: