Compatibilty with Spring Cloud Sleuth, which doesn´t work with multiple HttpComponentsHttpClientRequestFactory Beans

Author: jonashackt

client-bob/src/main/java/de/jonashackt/client/ServerClientImpl.java

@@ -1,32 +1,44 @@
 package de.jonashackt.client;
 
+import org.apache.http.client.HttpClient;
+import org.apache.http.impl.client.HttpClients;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
 import org.springframework.stereotype.Component;
 import org.springframework.web.client.RestTemplate;
 
+import javax.net.ssl.SSLContext;
+
 @Component
 public class ServerClientImpl implements ServerClient {
 
     @Autowired
-    private HttpComponentsClientHttpRequestFactory serverAliceClientHttpRequestFactory;
+    private SSLContext serverTomSSLContext;
 
     @Autowired
-    private HttpComponentsClientHttpRequestFactory serverTomClientHttpRequestFactory;
+    private SSLContext serverAliceSSLContext;
 
     private RestTemplate restTemplate = new RestTemplate();
 
     @Override
     public String callServerAlice() {
-        restTemplate.setRequestFactory(serverAliceClientHttpRequestFactory);
+        restTemplate.setRequestFactory(createHttpComponentsClientHttpRequestFactory(serverAliceSSLContext));
 
         return restTemplate.getForObject("https://server-alice:8443/hello", String.class);
     }
 
     @Override
     public String callServerTom() {
-        restTemplate.setRequestFactory(serverTomClientHttpRequestFactory);
+        restTemplate.setRequestFactory(createHttpComponentsClientHttpRequestFactory(serverTomSSLContext));
 
         return restTemplate.getForObject("https://server-tom:8443/hello", String.class);
     }
+
+    private HttpComponentsClientHttpRequestFactory createHttpComponentsClientHttpRequestFactory(SSLContext sslContext) {
+        HttpClient client = HttpClients.custom()
+                .setSSLContext(sslContext)
+                .build();
+
+        return new HttpComponentsClientHttpRequestFactory(client);
+    }
 }

client-bob/src/main/java/de/jonashackt/configuration/RestClientCertConfiguration.java

@@ -19,6 +19,7 @@ public class RestClientCertConfiguration {
 
     private char[] bobPassword = "bobpassword".toCharArray();
     private char[] tomPassword = "tompassword".toCharArray();
+    private char[] alicePassword = "alicepassword".toCharArray();
 
     @Value("classpath:alice-keystore.p12")
     private Resource aliceKeystoreResource;
@@ -28,38 +29,31 @@ public class RestClientCertConfiguration {
 
     @Value("classpath:client-truststore.jks")
     private Resource truststoreResource;
-    private char[] alicePassword = "alicepassword".toCharArray();
 
     @Bean
-    public HttpComponentsClientHttpRequestFactory serverTomClientHttpRequestFactory() throws Exception {
-        SSLContext sslContext = SSLContextBuilder
+    public SSLContext serverTomSSLContext() throws Exception {
+        return SSLContextBuilder
                 .create()
                 .loadKeyMaterial(inStream2File(tomKeystoreResource), tomPassword, tomPassword)
                 .loadTrustMaterial(inStream2File(truststoreResource), bobPassword)
                 .build();
-
-        HttpClient client = HttpClients.custom()
-                .setSSLContext(sslContext)
-                .build();
-
-        return new HttpComponentsClientHttpRequestFactory(client);
     }
 
     @Bean
-    public HttpComponentsClientHttpRequestFactory serverAliceClientHttpRequestFactory() throws Exception {
-        SSLContext sslContext = SSLContextBuilder
+    public SSLContext serverAliceSSLContext() throws Exception {
+        return SSLContextBuilder
                 .create()
                 .loadKeyMaterial(inStream2File(aliceKeystoreResource), alicePassword, alicePassword)
                 .loadTrustMaterial(inStream2File(truststoreResource), bobPassword)
                 .build();
-
-        HttpClient client = HttpClients.custom()
-                .setSSLContext(sslContext)
-                .build();
-
-        return new HttpComponentsClientHttpRequestFactory(client);
     }
 
+
+    /**
+     * The ugly need to generate a File from a InputStream - because SSLContextBuild.loadKeyMaterial only accepts File,
+     * but retrieving Files from within Spring Boot Fatjars is only possible through Resources ->
+     * see https://stackoverflow.com/questions/25869428/classpath-resource-not-found-when-running-as-jar
+     */
     private File inStream2File(Resource resource) {
         try {
             File tempFile = File.createTempFile("file", ".tmp");