Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: marijnh/Eloquent-JavaScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: jmrog/Eloquent-JavaScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 20, 2014

  1. Add 'table-layout: fixed' to book's CSS in Ch. 15 

    This commit adds a line -- 'table-layout:fixed' -- to the
'.background' CSS displayed in the book's Chapter 15 ('Project: A
Platform Game'). This line is required in order for the game to
function properly in Google Chrome (at least versions 38 and 39). If
the line is not included, Google Chrome's table layout algorithm can
alter the size of the table cells constituting the game's background,
resulting in buggy behavior (e.g., the player will 'hit' walls before
the player icon is actually touching a displayed wall).

The relevant line is already included in the downloadable code for the
book. This commit simply adds it, together with a brief explanation, to
the CSS displayed in the book text, so that readers who are typing
along with the book will end up with a working game.
    Jason Rogers committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    d192b38 View commit details
    Browse the repository at this point in the history
Loading