[birdofpreyru#28] iOS/macOS: Fixes the handling of security scopes by pickFile() and other methods

Author: birdofpreyru

README.md

@@ -855,6 +855,18 @@ crash the app.
   allowing a direct access to them with other methods in this library
   (_e.g._ [readFile()]), even if the file is outside the app sandbox.
 
+  **NOTE:** On **iOS** & **macOS** it resolve to special values with the format
+  &laquo;`bookmark://<BASE64_ENCODED_STRING>`&raquo;, rather than normal URIs.
+  It is necessary for the support of security scopes
+  (see [Bookmarks and Security Scopes](https://developer.apple.com/documentation/foundation/nsurl#1663783)) in library methods. The &laquo;`<BASE64_ENCODED_STRING>`&raquo;
+  in this case is a Base64-encoded binary representation of the URL bookmark,
+  along with its security scope data. Other methods of the library are expected
+  to automatically handle such special URIs as needed.
+
+  **BEWARE:** It has not been thoroughly verified yet that all library methods
+  support these &laquo;Bookmark URLs&raquo; correctly. The expected error in
+  such case is a failure to access the URLs as non-existing.
+
 ### read()
 [read()]: #read
 ```ts

example/ios/Podfile.lock

@@ -2,7 +2,7 @@ PODS:
   - boost (1.83.0)
   - CocoaAsyncSocket (7.6.5)
   - DoubleConversion (1.1.6)
-  - dr-pogodin-react-native-fs (2.22.1):
+  - dr-pogodin-react-native-fs (2.22.2):
     - glog
     - hermes-engine
     - RCT-Folly (= 2022.05.16.00)
@@ -1402,7 +1402,7 @@ SPEC CHECKSUMS:
   boost: d3f49c53809116a5d38da093a8aa78bf551aed09
   CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
   DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
-  dr-pogodin-react-native-fs: 60d98fc542ed310f57d9b497628f6e72fa2d5e2a
+  dr-pogodin-react-native-fs: 6aaacfa553d2a4be14cf32e4053725b7057155ee
   dr-pogodin-react-native-static-server: a0ab88663817dfc8791b3e88295d0d9b6d212c5f
   FBLazyVector: fbc4957d9aa695250b55d879c1d86f79d7e69ab4
   Flipper: c7a0093234c4bdd456e363f2f19b2e4b27652d44
@@ -1468,4 +1468,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 2673e1121fca9666d2df5c7ba3b5b287e79ba95f
 
-COCOAPODS: 1.14.3
+COCOAPODS: 1.15.0

example/src/TestBaseMethods.tsx

@@ -919,7 +919,7 @@ const tests: { [name: string]: StatusOrEvaluator } = {
         } else {
           if (
             !isMatch(e, {
-              code: 'ENSCOCOAERRORDOMAIN260',
+              code: 'NSCocoaErrorDomain:260',
               message:
                 'The file “non-existing-file.txt” couldn’t be opened because there is no such file.',
             })

ios/RNFSException.h

@@ -6,7 +6,10 @@
 - (RNFSException*) log;
 - (void) reject:(RCTPromiseRejectBlock)reject;
 - (void) reject:(RCTPromiseRejectBlock)reject details:(NSString*)details;
-+ (RNFSException*) from: (NSException*)exception;
+
++ (RNFSException*) fromError:(NSError*)error;
++ (RNFSException*) fromException:(NSException*)exception;
+
 + (RNFSException*) name: (NSString*)name;
 + (RNFSException*) name: (NSString*)name details: (NSString*)details;
 

ios/RNFSException.mm

@@ -40,13 +40,22 @@ - (void) reject: (RCTPromiseRejectBlock)reject details: (NSString*) details
   reject(self.name, reason, [self error]);
 }
 
-+ (RNFSException*) from: (NSException*)exception
++ (RNFSException*) fromError:(NSError *)error
+{
+  NSString *name = [NSString stringWithFormat:@"%@:%ld",
+                    error.domain, error.code];
+  return [[RNFSException alloc]
+          initWithName:name
+          reason:error.localizedDescription
+          userInfo:error.userInfo];
+}
+
++ (RNFSException*) fromException:(NSException *)exception
 {
   return [[RNFSException alloc]
           initWithName: exception.name
           reason: exception.reason
-          userInfo: exception.userInfo
-  ];
+          userInfo: exception.userInfo];
 }
 
 + (RNFSException*) name: (NSString*)name