Preparing downloader for depedency system.

Author: James Campbell

lib/cocoapods-deploy/deploy_downloader.rb

@@ -15,18 +15,23 @@ def download(config)
       end
     end
 
-    #Download Normal
     def download_source(config)
       # TODO: Method for looping through dependency
       source = ExternalSources.from_dependency(dependency, config.podfile.defined_in_file)
       source.fetch(config.sandbox)
     end
 
-    #Download Podspecs
     def download_podspec(config)
-      # TODO: Method for looping through dependency
-      source = ExternalSources.from_dependency(dependency, config.podfile.defined_in_file)
-      source.fetch(config.sandbox)
+      dependencies_for_sources(config).each do |dep|
+        source = ExternalSources.from_dependency(dep, config.podfile.defined_in_file)
+        source.fetch(config.sandbox)
+      end
+    end
+
+    private
+
+    def dependencies_for_sources(config)
+      []
     end
   end
 end

spec/deploy_downloader_spec.rb

@@ -16,30 +16,39 @@ module Pod
       Config.instance.stubs(:podfile).returns(@podfile)
 
       @source = MockExternalSource.new
-      ExternalSources.stubs(:from_dependency).returns(@source)
     end
 
     it "should external source outside of repo" do
       dependency = Dependency.new("AFNetworking", { :git => "https://github.com/gowalla/AFNetworking.git"})
       downloader = DeployDownloader.new(dependency)
 
+      ExternalSources.stubs(:from_dependency).returns(@source)
       @source.expects(:fetch)
+
       downloader.download(Config.instance)
     end
 
     it "should download source from main repo" do
-      dependency = Dependency.new("AFNetworking", { :podspec => "http://github.com/CocoaPods/Specs.git/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
+      dependency = Dependency.new("AFNetworking", { :podspec => "{root-url}/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
       downloader = DeployDownloader.new(dependency)
+      expected_dependency = Dependency.new("AFNetworking", { :podspec => "http://github.com/My/Repo.git/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
 
+      ExternalSources.expects(:from_dependency).with(expected_dependency, @podfile.defined_in_file)
+      ExternalSources.stubs(:from_dependency).returns(@source)
       @source.expects(:fetch)
+
       downloader.download(Config.instance)
     end
 
     it "should download source from external repo" do
-      dependency = Dependency.new("AFNetworking", { :podspec => "http://github.com/My/Repo.git/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
+      dependency = Dependency.new("AFNetworking", { :podspec => "{root-url}/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
       downloader = DeployDownloader.new(dependency)
+      expected_dependency = Dependency.new("AFNetworking", { :podspec => "http://github.com/CocoaPods/Specs.git/master/Specs/AFNetworking/1.0/AFNetworking.podspec.json"})
 
+      ExternalSources.expects(:from_dependency).with(expected_dependency, @podfile.defined_in_file)
+      ExternalSources.stubs(:from_dependency).returns(@source)
       @source.expects(:fetch)
+
       downloader.download(Config.instance)
     end
   end