Skip to content

Commit adeda82

Browse files
committed
Fixes to copy
1 parent d0a1bf6 commit adeda82

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ A react native android wrapper for SQLite
44

55
## Rationale
66

7-
React Native doesn't have a built-in module to access Sqlite database, either in iOS or Android.
7+
React Native doesn't have a built-in module to access Sqlite databases, either in iOS or Android.
88

9-
This library intents to fill the gap in the Android side.
9+
This library intends to fill the gap in the Android side.
1010

1111
## Setup
1212

@@ -41,6 +41,7 @@ dependencies {
4141
import java.util.Arrays;
4242
import java.util.List;
4343

44+
// Make sure to import these classes
4445
import com.facebook.react.bridge.NativeModule;
4546
import com.facebook.react.modules.fresco.FrescoModule;
4647
import com.facebook.react.modules.network.NetworkingModule;
@@ -52,6 +53,7 @@ import io.jbrodriguez.react.DBManager
5253
public class MainActivity extends Activity implements DefaultHardwareBackBtnHandler {
5354
...
5455

56+
// create this class
5557
private class AppPackage extends MainReactPackage {
5658
@Override
5759
public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) {
@@ -88,15 +90,15 @@ public class MainActivity extends Activity implements DefaultHardwareBackBtnHand
8890
}
8991
```
9092

91-
Please note that the `createNativeModules` function deviates from the standard proposal from Facebook, because it didn't work.
93+
Please note that the `createNativeModules` function deviates from the standard docs from Facebook, because it didn't work.
9294

9395
At this early stage in RN Android, I suspect it's a bug more than anything else.
9496

9597
## Usage
9698

9799
This library depends on [SQLiteAssetHelper](https://github.com/jgilfelt/android-sqlite-asset-helper).
98100

99-
The idea is that you `import` your previously created database as an application's asset.
101+
The idea is that you `import` your previously created database as an application asset.
100102

101103
SQLiteAssetHelper manages schema definition (create), as well as upgrades.
102104

@@ -169,7 +171,7 @@ sqlite.query(sql, params)
169171
* It doesn't return the id for a newly inserted row (maybe create a separate insert function ?)
170172
* Column types currently supported are Integer and String
171173
* Additional error handling should be implemented
172-
* The `createNativeModules` function eventually needs to return to official documentation's spec
174+
* The `createNativeModules` function eventually needs to return to official docs' spec
173175
* Although I'm using it in my personal projects, it's still an early release. Please do read the [license](https://github.com/jbrodriguz/react-native-android-sqlite/README.md)
174176

175177
## Changes

0 commit comments

Comments
 (0)