-
Notifications
You must be signed in to change notification settings - Fork 506
Comparing changes
Open a pull request
base repository: jaredpalmer/tsdx
base: v0.14.1
head repository: jaredpalmer/tsdx
compare: master
- 11 commits
- 47 files changed
- 6 contributors
Commits on Oct 14, 2020
-
refactor: move unbundled regenerator test to build-options
- I accidentally put it into build-default before build-options existed, but the test very specifically tests an option, `--target node`, so it should be in build-options as that's not a zero-config default
Configuration menu - View commit details
-
Copy full SHA for 6ad18ba - Browse repository at this point
Copy the full SHA 6ad18baView commit details -
refactor: use a less noisy side-effect for async regression test
- the previous console.log statement would actually log out because one of the tests imports (`require`s) the actual built library in order to ensure correctness - during the import, the side-effect runs and prints, which ends up actually printing out during the test, which was quite noisy 😅 - we do still want a side-effect so the whole statement doesn't get removed as dead code, so use a global variable assignment instead
Configuration menu - View commit details
-
Copy full SHA for fcd2639 - Browse repository at this point
Copy the full SHA fcd2639View commit details -
refactor: be more descriptive than "blah", "foo", "bar" in tests
- instead of random names (which are bad practice), be very explicit about what the variables _should_ be - also add comments to some of the regression tests that didn't have any to describe them - similarly, when testing dev only logging, say that directly - and, in this case, instead of using an unnecessary swear word - the third contributor PR to TSDX removed some similar swear words in the templates - these were changed to "boop" and now similarly changed to be more descriptive - which is better practice anyway, not encouraging bad practices via the templates, and should also be easier to understand for newcomers - similarly, intead of "blah" and "works" in template tests, actually describe what the tests do - similarly encourage better practices in the tests - also rename template tests from "blah.test.ts" to "index.test.ts" because they test "index.ts" and it's common convention to name them the same - and fix a leftover "describe('it')" in the react template when it should be "describe('Thing')" which the storybook template has - "it" is also confusing when used together with the Jest "it" global - could use something better than "Thing" as well (e.g. "SomeComponent"), but don't want to dig through and re-test the Storybook pieces right now
Configuration menu - View commit details
-
Copy full SHA for 26c56a7 - Browse repository at this point
Copy the full SHA 26c56a7View commit details -
fix/docs: basic README should reference .ts, not .tsx files
- it uses normal .ts files and no JSX (that's what the React template is for after all), so README shouldn't mention .tsx - woops, this was probably a copy+paste error on my behalf when I was improving the basic template's docs
Configuration menu - View commit details
-
Copy full SHA for 1c14079 - Browse repository at this point
Copy the full SHA 1c14079View commit details -
refactor/test: test for correctness of syntax, not just parsing
- have most of the syntax tests export a function that returns true if the syntax is evaluated correctly, and test that it does in fact return true - just using `true` as something consistent and easy to test for - change the async test to move the side effect before the Promise resolves - not entirely sure why, potentially because of the way the event loop works (race condition), but this was returning false when after and true when before - both work as a side effect, so just have it before
1Configuration menu - View commit details
-
Copy full SHA for 30d69d9 - Browse repository at this point
Copy the full SHA 30d69d9View commit details -
deps: ignore dependabot for peer dependencies (#904)
- several of the dependencies in the tree are only there because they are peerDeps, and not because we directly depend on them - they should only be upgraded in tandem with the dep(s) they are peers of and pretty much never in isolation - Greenkeeper made several PRs for peers which previously caused an erroneous/buggy update of `@types/jest` to 25 many months before Jest was upgraded to 25 - and honestly those Greenkeeper PRs for peers had confused me a good deal too
1Configuration menu - View commit details
-
Copy full SHA for 569c3ed - Browse repository at this point
Copy the full SHA 569c3edView commit details
Commits on Nov 4, 2020
-
fix: relative links in website to absolute links (#923)
- relative links in website were not working as the files can't be viewed on the site - these were erroneously copy+pasted from the README, where the relative links work by pointing to files in the repo - those relative links don't work on the website - use absolute links instead to the main fork of the repo's `master` branch - this has a few caveats now, in that the README has a bit more desync from the website now and that, unlike the README, these point to a specific fork and branch - the README points to the same version; regardless if forked or on a different branch, it'll point to that branch's code
1Configuration menu - View commit details
-
Copy full SHA for 6078acb - Browse repository at this point
Copy the full SHA 6078acbView commit details -
docs: add felixmosh as a contributor (#924)
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
1Configuration menu - View commit details
-
Copy full SHA for 995099f - Browse repository at this point
Copy the full SHA 995099fView commit details
Commits on Nov 10, 2020
-
1
Configuration menu - View commit details
-
Copy full SHA for 462af2d - Browse repository at this point
Copy the full SHA 462af2dView commit details
Commits on Sep 20, 2021
-
Add formium discord badge (#1078)
Co-authored-by: Jared Palmer <jared@palmer.net>
1Configuration menu - View commit details
-
Copy full SHA for 9dc28f2 - Browse repository at this point
Copy the full SHA 9dc28f2View commit details
Commits on Feb 28, 2022
-
feat: ESNext by default, full ESM-CJS interop, max minification (#1059)
Co-authored-by: Jared Palmer <jared@palmer.net>
Configuration menu - View commit details
-
Copy full SHA for 2d7981b - Browse repository at this point
Copy the full SHA 2d7981bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.14.1...master