Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jaredpalmer/tsdx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.14.1
Choose a base ref
...
head repository: jaredpalmer/tsdx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 11 commits
  • 47 files changed
  • 6 contributors

Commits on Oct 14, 2020

  1. refactor: move unbundled regenerator test to build-options

    - I accidentally put it into build-default before build-options existed,
      but the test very specifically tests an option, `--target node`, so
      it should be in build-options as that's not a zero-config default
    agilgur5 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    6ad18ba View commit details
    Browse the repository at this point in the history
  2. refactor: use a less noisy side-effect for async regression test

    - the previous console.log statement would actually log out because
      one of the tests imports (`require`s) the actual built library in
      order to ensure correctness
      - during the import, the side-effect runs and prints, which ends up
        actually printing out during the test, which was quite noisy 😅
    
    - we do still want a side-effect so the whole statement doesn't get
      removed as dead code, so use a global variable assignment instead
    agilgur5 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    fcd2639 View commit details
    Browse the repository at this point in the history
  3. refactor: be more descriptive than "blah", "foo", "bar" in tests

    - instead of random names (which are bad practice), be very explicit
      about what the variables _should_ be
    - also add comments to some of the regression tests that didn't have
      any to describe them
    
    - similarly, when testing dev only logging, say that directly
      - and, in this case, instead of using an unnecessary swear word
        - the third contributor PR to TSDX removed some similar swear words
          in the templates
          - these were changed to "boop" and now similarly changed to be
            more descriptive
            - which is better practice anyway, not encouraging bad practices
              via the templates, and should also be easier to understand for
              newcomers
    
    - similarly, intead of "blah" and "works" in template tests, actually
      describe what the tests do
      - similarly encourage better practices in the tests
    
    - also rename template tests from "blah.test.ts" to "index.test.ts"
      because they test "index.ts" and it's common convention to name them
      the same
    
    - and fix a leftover "describe('it')" in the react template when it
      should be "describe('Thing')" which the storybook template has
      - "it" is also confusing when used together with the Jest "it" global
      - could use something better than "Thing" as well (e.g.
        "SomeComponent"), but don't want to dig through and re-test the
        Storybook pieces right now
    agilgur5 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    26c56a7 View commit details
    Browse the repository at this point in the history
  4. fix/docs: basic README should reference .ts, not .tsx files

    - it uses normal .ts files and no JSX (that's what the React template
      is for after all), so README shouldn't mention .tsx
    
    - woops, this was probably a copy+paste error on my behalf when I was
      improving the basic template's docs
    agilgur5 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1c14079 View commit details
    Browse the repository at this point in the history
  5. refactor/test: test for correctness of syntax, not just parsing

    - have most of the syntax tests export a function that returns true
      if the syntax is evaluated correctly, and test that it does in fact
      return true
      - just using `true` as something consistent and easy to test for
    
    - change the async test to move the side effect before the Promise
      resolves
      - not entirely sure why, potentially because of the way the event
        loop works (race condition), but this was returning false when
        after and true when before
        - both work as a side effect, so just have it before
    agilgur5 committed Oct 14, 2020
    1 Configuration menu
    Copy the full SHA
    30d69d9 View commit details
    Browse the repository at this point in the history
  6. deps: ignore dependabot for peer dependencies (#904)

    - several of the dependencies in the tree are only there because they
      are peerDeps, and not because we directly depend on them
      - they should only be upgraded in tandem with the dep(s) they are
        peers of and pretty much never in isolation
    
    - Greenkeeper made several PRs for peers which previously caused an
      erroneous/buggy update of `@types/jest` to 25 many months before Jest
      was upgraded to 25
      - and honestly those Greenkeeper PRs for peers had confused me a
        good deal too
    agilgur5 authored Oct 14, 2020
    1 Configuration menu
    Copy the full SHA
    569c3ed View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. fix: relative links in website to absolute links (#923)

    - relative links in website were not working as the files can't be viewed
      on the site
      - these were erroneously copy+pasted from the README, where the relative
        links work by pointing to files in the repo
        - those relative links don't work on the website
    
    - use absolute links instead to the main fork of the repo's `master` branch
      - this has a few caveats now, in that the README has a bit more desync from
        the website now and that, unlike the README, these point to a specific
        fork and branch
        - the README points to the same version; regardless if forked or on a
          different branch, it'll point to that branch's code
    felixmosh authored Nov 4, 2020
    1 Configuration menu
    Copy the full SHA
    6078acb View commit details
    Browse the repository at this point in the history
  2. docs: add felixmosh as a contributor (#924)

    * docs: update README.md [skip ci]
    
    * docs: update .all-contributorsrc [skip ci]
    
    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    allcontributors[bot] authored Nov 4, 2020
    1 Configuration menu
    Copy the full SHA
    995099f View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. 1 Configuration menu
    Copy the full SHA
    462af2d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Add formium discord badge (#1078)

    Co-authored-by: Jared Palmer <jared@palmer.net>
    imgbot[bot] and jaredpalmer authored Sep 20, 2021
    1 Configuration menu
    Copy the full SHA
    9dc28f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. feat: ESNext by default, full ESM-CJS interop, max minification (#1059)

    Co-authored-by: Jared Palmer <jared@palmer.net>
    ctjlewis and jaredpalmer authored Feb 28, 2022
    Configuration menu
    Copy the full SHA
    2d7981b View commit details
    Browse the repository at this point in the history
Loading