Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jaredpalmer/tsdx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.14.0
Choose a base ref
...
head repository: jaredpalmer/tsdx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.14.1
Choose a head ref
  • 10 commits
  • 9 files changed
  • 6 contributors

Commits on Oct 5, 2020

  1. Use compatible eslint-config-react-app and eslint-plugin-react-hooks. (

    …#890)
    
    This solves the following warning on yarn install:
    
    `eslint-config-react-app@5.0.2" has incorrect peer dependency "eslint-plugin-react-hooks@1.x".`
    
    `eslint-config-react-app@5.2.1` has widened its peerDep range to include `eslint-plugin-react-hooks@2`: https://github.com/facebook/create-react-app/blob/d2f813f8897ffcd2f0b0d2da75d0c44924c92f4d/packages/eslint-config-react-app/package.json#L26
    ludofischer authored Oct 5, 2020
    1 Configuration menu
    Copy the full SHA
    57f7dcc View commit details
    Browse the repository at this point in the history
  2. docs: add ludofischer as a contributor (#894)

    * docs: update README.md [skip ci]
    
    * docs: update .all-contributorsrc [skip ci]
    
    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    allcontributors[bot] authored Oct 5, 2020
    1 Configuration menu
    Copy the full SHA
    da53ea8 View commit details
    Browse the repository at this point in the history
  3. fix: don't replace lodash/fp imports with lodash-es/fp

    - previously, when importing modules from `lodash/fp`, the imports broke
      since `babel-plugin-transform-rename-import` renames all `lodash`
      imports to `lodash-es` for the ESM build
      - e.g `import mergeAll from 'lodash/fp/mergeAll';` ends up being
        imported as `import mergeAll from 'lodash-es/fp/mergeAll'`
        and we got an error since `lodash-es/fp` doesn't exist
    
    - with this fix we use a regex instead of bare string for replacement
      and add a negative lookahead to it so that it doesn't replace
      `lodash/fp` imports
    
    Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
    Altrim Beqiri and agilgur5 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    8b91c74 View commit details
    Browse the repository at this point in the history
  4. test: ensure lodash-es replacement is done properly

    - lodash for CJS, lodash-es for ESM
    
    - previously, there were no tests for this behavior, so this adds them
      to ensure the replacement continues to work, even with the new
      fix with regex lookahead for `lodash/fp`
    
    Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
    Altrim Beqiri and agilgur5 committed Oct 5, 2020
    1 Configuration menu
    Copy the full SHA
    9c4ce68 View commit details
    Browse the repository at this point in the history
  5. docs: add altrim as a contributor (#895)

    * docs: update README.md [skip ci]
    
    * docs: update .all-contributorsrc [skip ci]
    
    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    allcontributors[bot] authored Oct 5, 2020
    1 Configuration menu
    Copy the full SHA
    d292dd9 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. 1 Configuration menu
    Copy the full SHA
    e3e80d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. fix/deps: upgrade rpts2 to fix cache issue

    - fixes a cache issue with certain builds by upgrading to the most
      recent version of rollup-plugin-typescript2, v0.27.3, which just had
      a PR and release for this specific cache issue 2 weeks ago
      - there were no relevant breaking changes in the upgrade from rpts2
        v0.26 to v0.27.0, so this should be a straight bugfix
    tanem authored and agilgur5 committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    eaa1c3b View commit details
    Browse the repository at this point in the history
  2. test: add a smoke test that builds _all_ formats

    - there was never a test that built all, meaning tests left out the
      somewhat popular UMD build in particular
      - per my investigation, CJS + UMD, CJS + System, UMD + System started
        bugging out recently due to an upstream bug, but this wasn't known
        proactively because there were no tests for it
        - and I also found that CJS + System actually was bugging out in
          the previous version, TSDX v0.13.3, but I'm guessing no one
          reported it back then as it's an unpopular combination of formats
    
    - this test fails prior to upgrade of rpts2 to v0.27.3 and succeeds
      after the upgrade
      - so this should act as a regression test against this bug as well
    
    - created a new e2e build-options test file for this because
      build-default is meant to have 0 options and test only the defaults
      - had to give it a differentiated "stage" name as it uses the same
        build-default fixture and so breaks during test parallelization
        without that
      - should also move the regeneratorRuntime `--target node` test here
        since that's an option and not a default
    agilgur5 committed Oct 12, 2020
    1 Configuration menu
    Copy the full SHA
    e2f1b76 View commit details
    Browse the repository at this point in the history
  3. docs: add tanem as a contributor (#902)

    * docs: update README.md [skip ci]
    
    * docs: update .all-contributorsrc [skip ci]
    
    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
    allcontributors[bot] authored Oct 12, 2020
    1 Configuration menu
    Copy the full SHA
    81c8b2d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. v0.14.1

    agilgur5 committed Oct 13, 2020
    1 Configuration menu
    Copy the full SHA
    64c5094 View commit details
    Browse the repository at this point in the history
Loading