diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 354f2c66f..6ba924f37 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -1,6 +1,8 @@ name: Node CI -on: [push, pull_request] +on: + pull_request: + types: [opened, synchronize, reopened] jobs: lint: @@ -26,7 +28,7 @@ jobs: strategy: matrix: - node: ['8.12.x', '10.x', '12.x'] + node: ['10.x', '12.x', '13.x'] os: [ubuntu-latest, windows-latest, macOS-latest] name: Test on node ${{ matrix.node }} and ${{ matrix.os }} @@ -42,4 +44,4 @@ jobs: run: yarn install --frozen-lockfile - name: Test package - run: yarn test + run: yarn test --runInBand diff --git a/README.md b/README.md index 58ae2b0c7..5beb9431a 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,7 @@ Despite all the recent hype, setting up a new TypeScript (x React) library can b - [`tsdx build`](#tsdx-build) - [`tsdx test`](#tsdx-test) - [`tsdx lint`](#tsdx-lint) +- [Contributing](#contributing) - [Author](#author) - [License](#license) - [Contributors ✨](#contributors-) @@ -452,16 +453,14 @@ Examples ### `tsdx test` -This runs Jest v24.x in watch mode. See [https://jestjs.io](https://jestjs.io) for options. - -If you would like to disable watch mode, you can set the environment variable `CI=true`. For instance, you could set up your `package.json` `scripts` like: +This runs Jest v24.x. See [https://jestjs.io](https://jestjs.io) for options. For example, if you would like to run in watch mode, you can run `tsdx test --watch`. So you could set up your `package.json` `scripts` like: ```json { "scripts": { - "test": "CI=true tsdx test", - "test:watch": "tsdx test", - "test:coverage": "CI=true tsdx test --coverage" + "test": "tsdx test", + "test:watch": "tsdx test --watch", + "test:coverage": "tsdx test --coverage" } } ``` diff --git a/package.json b/package.json index 3e1cd4683..b85a3e8c2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "tsdx", - "version": "0.12.2", + "version": "0.12.3", "author": "Jared Palmer ", "description": "Zero-config TypeScript package development", "license": "MIT", diff --git a/src/index.ts b/src/index.ts index 2096a29c9..e059c8358 100755 --- a/src/index.ts +++ b/src/index.ts @@ -529,10 +529,6 @@ prog }) ); - if (!process.env.CI) { - argv.push('--watch'); // run jest in watch mode unless in CI - } - const [, ...argsToPassToJestCli] = argv; jest.run(argsToPassToJestCli); });