Skip to content

Commit edd8045

Browse files
authored
(deps/fix/types): upgrade rollup & fix event type issues (#544)
- if TSDX were installed directly from git, the `prepare` script would for some reason fail on these events - but they wouldn't error when run internally - when Rollup was upgraded, then they started erroring - also remove the unnecessary await in front of watch
1 parent 10e54d5 commit edd8045

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"pascal-case": "^2.0.1",
8787
"prettier": "^1.19.1",
8888
"progress-estimator": "^0.2.2",
89-
"rollup": "^1.27.8",
89+
"rollup": "^1.32.1",
9090
"rollup-plugin-babel": "^4.3.2",
9191
"rollup-plugin-sourcemaps": "^0.4.2",
9292
"rollup-plugin-terser": "^5.1.2",

src/index.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ prog
321321
}
322322

323323
const spinner = ora().start();
324-
await watch(
324+
watch(
325325
(buildConfigs as RollupWatchOptions[]).map(inputOptions => ({
326326
watch: {
327327
silent: true,
@@ -345,11 +345,6 @@ prog
345345
logError(event.error);
346346
failureKiller = run(opts.onFailure);
347347
}
348-
if (event.code === 'FATAL') {
349-
spinner.fail(chalk.bold.red('Failed to compile'));
350-
logError(event.error);
351-
failureKiller = run(opts.onFailure);
352-
}
353348
if (event.code === 'END') {
354349
spinner.succeed(chalk.bold.green('Compiled successfully'));
355350
console.log(`

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5656,10 +5656,10 @@ rollup@^0.63.4:
56565656
"@types/estree" "0.0.39"
56575657
"@types/node" "*"
56585658

5659-
rollup@^1.27.8:
5660-
version "1.27.8"
5661-
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.27.8.tgz#94288a957af9f4c2380b73a17494d87705997d0f"
5662-
integrity sha512-EVoEV5rAWl+5clnGznt1KY8PeVkzVQh/R0d2s3gHEkN7gfoyC4JmvIVuCtPbYE8NM5Ep/g+nAmvKXBjzaqTsHA==
5659+
rollup@^1.32.1:
5660+
version "1.32.1"
5661+
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.32.1.tgz#4480e52d9d9e2ae4b46ba0d9ddeaf3163940f9c4"
5662+
integrity sha512-/2HA0Ec70TvQnXdzynFffkjA6XN+1e2pEv/uKS5Ulca40g2L7KuOE3riasHoNVHOsFD5KKZgDsMk1CP3Tw9s+A==
56635663
dependencies:
56645664
"@types/estree" "*"
56655665
"@types/node" "*"

0 commit comments

Comments
 (0)