Skip to content

Commit 5c73483

Browse files
authored
(clean): remove redundant tsconfig strict opts in tests (#690)
- removed them in the templates in a previous commit, forgot to remove them in the tests too - presets would really help with this duplication / inconsistency problem - noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks, strictFunctionTypes, and strictPropertyInitialization are already enabled by strict, no need to configure them twice
1 parent 3c65bdf commit 5c73483

File tree

6 files changed

+0
-36
lines changed

6 files changed

+0
-36
lines changed

test/e2e/fixtures/build-default/tsconfig.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"sourceMap": true,
77
"rootDir": "./src",
88
"strict": true,
9-
"noImplicitAny": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"strictPropertyInitialization": true,
13-
"noImplicitThis": true,
14-
"alwaysStrict": true,
159
"noUnusedLocals": true,
1610
"noUnusedParameters": true,
1711
"noImplicitReturns": true,

test/e2e/fixtures/build-invalid/tsconfig.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"sourceMap": true,
77
"rootDir": "./src",
88
"strict": true,
9-
"noImplicitAny": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"strictPropertyInitialization": true,
13-
"noImplicitThis": true,
14-
"alwaysStrict": true,
159
"noUnusedLocals": true,
1610
"noUnusedParameters": true,
1711
"noImplicitReturns": true,

test/e2e/fixtures/build-withTsconfig/tsconfig.base.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
"sourceMap": true,
99
"rootDir": "./src",
1010
"strict": true,
11-
"noImplicitAny": true,
12-
"strictNullChecks": true,
13-
"strictFunctionTypes": true,
14-
"strictPropertyInitialization": true,
15-
"noImplicitThis": true,
16-
"alwaysStrict": true,
1711
"noUnusedLocals": true,
1812
"noUnusedParameters": true,
1913
"noImplicitReturns": true,

test/integration/fixtures/build-options/tsconfig.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"sourceMap": true,
77
"rootDir": "./src",
88
"strict": true,
9-
"noImplicitAny": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"strictPropertyInitialization": true,
13-
"noImplicitThis": true,
14-
"alwaysStrict": true,
159
"noUnusedLocals": true,
1610
"noUnusedParameters": true,
1711
"noImplicitReturns": true,

test/integration/fixtures/build-withBabel/tsconfig.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"sourceMap": true,
77
"rootDir": "./src",
88
"strict": true,
9-
"noImplicitAny": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"strictPropertyInitialization": true,
13-
"noImplicitThis": true,
14-
"alwaysStrict": true,
159
"noUnusedLocals": true,
1610
"noUnusedParameters": true,
1711
"noImplicitReturns": true,

test/integration/fixtures/build-withConfig/tsconfig.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@
66
"sourceMap": true,
77
"rootDir": "./src",
88
"strict": true,
9-
"noImplicitAny": true,
10-
"strictNullChecks": true,
11-
"strictFunctionTypes": true,
12-
"strictPropertyInitialization": true,
13-
"noImplicitThis": true,
14-
"alwaysStrict": true,
159
"noUnusedLocals": true,
1610
"noUnusedParameters": true,
1711
"noImplicitReturns": true,

0 commit comments

Comments
 (0)