Fix out of order result check in ICUPatternGenerator (swiftlang#374)

gwynne · web-flow · commit d2d865d56d94 · 2024-01-16T12:58:33.000-08:00
diff --git a/Sources/FoundationInternationalization/ICU/ICUPatternGenerator.swift b/Sources/FoundationInternationalization/ICU/ICUPatternGenerator.swift
@@ -38,8 +38,8 @@ final class ICUPatternGenerator {
 
     func _patternForSkeleton(_ skeleton: String) -> String {
         var status = U_ZERO_ERROR
-        try! status.checkSuccess()
         let clonedPatternGenerator = udatpg_clone(upatternGenerator, &status)
+        try! status.checkSuccess()
         defer {
              udatpg_close(clonedPatternGenerator)
         }

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,8 @@ final class ICUPatternGenerator {`
`38`	`38`
`39`	`39`	`func _patternForSkeleton(_ skeleton: String) -> String {`
`40`	`40`	`var status = U_ZERO_ERROR`
`41`		`- try! status.checkSuccess()`
`42`	`41`	`let clonedPatternGenerator = udatpg_clone(upatternGenerator, &status)`
	`42`	`+ try! status.checkSuccess()`
`43`	`43`	`defer {`
`44`	`44`	`udatpg_close(clonedPatternGenerator)`
`45`	`45`	`}`