Ensure projects are updated for find all references (microsoft#52583)

Author: gabritto

src/compiler/program.ts

@@ -961,14 +961,14 @@ export function createModuleResolutionLoader(
 ): ResolutionLoader<StringLiteralLike, ResolvedModuleWithFailedLookupLocations, SourceFile> {
     return {
         nameAndMode: moduleResolutionNameAndModeGetter,
-        resolve: (moduleName, resoluionMode) => resolveModuleName(
+        resolve: (moduleName, resolutionMode) => resolveModuleName(
             moduleName,
             containingFile,
             options,
             host,
             cache,
             redirectedReference,
-            resoluionMode,
+            resolutionMode,
         ),
     };
 }

src/server/session.ts

@@ -730,6 +730,12 @@ function getPerProjectReferences<TResult>(
             if (resultsMap.has(project)) continue;
             if (isLocationProjectReferenceRedirect(project, location)) continue;
 
+            // The project could be dirty and could no longer contain the location's file after it's updated,
+            // so we need to update the project and check if it still contains the file.
+            updateProjectIfDirty(project);
+            if (!project.containsFile(toNormalizedPath(location.fileName))) {
+                continue;
+            }
             const projectResults = searchPosition(project, location);
             resultsMap.set(project, projectResults ?? emptyArray);
             searchedProjectKeys.add(getProjectKey(project));

src/testRunner/tests.ts

@@ -53,6 +53,7 @@ import "./unittests/services/extract/constants";
 import "./unittests/services/extract/functions";
 import "./unittests/services/extract/symbolWalker";
 import "./unittests/services/extract/ranges";
+import "./unittests/services/findAllReferences";
 import "./unittests/services/hostNewLineSupport";
 import "./unittests/services/languageService";
 import "./unittests/services/organizeImports";

src/testRunner/unittests/services/findAllReferences.ts

@@ -0,0 +1,141 @@
+import { protocol } from "../../_namespaces/ts.server";
+import { baselineTsserverLogs, createLoggerWithInMemoryLogs, createSession } from "../tsserver/helpers";
+import { createServerHost, File } from "../virtualFileSystemWithWatch";
+
+describe("unittests:: services:: findAllReferences", () => {
+    it("does not try to open a file in a project that was updated and no longer has the file", () => {
+        const files: File[] = [
+            {
+                path: "/packages/babel-loader/tsconfig.json",
+                content:
+`
+{
+    "compilerOptions": {
+        "target": "ES2018",
+        "module": "commonjs",
+        "strict": true,
+        "esModuleInterop": true,
+        "composite": true,
+        "rootDir": "src",
+        "outDir": "dist"
+    },
+    "include": ["src"],
+    "references": [{"path": "../core"}]
+}
+`
+            },
+            {
+                path: "/packages/babel-loader/src/index.ts",
+                content:
+`
+import type { Foo } from "../../core/src/index.js";
+`
+            },
+            {
+                path: "/packages/core/tsconfig.json",
+                content:
+`
+{
+    "compilerOptions": {
+        "target": "ES2018",
+        "module": "commonjs",
+        "strict": true,
+        "esModuleInterop": true,
+        "composite": true,
+        "rootDir": "./src",
+        "outDir": "./dist",
+    },
+    "include": ["./src"]
+}
+`
+            },
+            {
+                path: "/packages/core/src/index.ts",
+                content:
+`
+import { Bar } from "./loading-indicator.js";
+export type Foo = {};
+const bar: Bar = {
+    prop: 0
+}
+`
+            },
+            {
+                path: "/packages/core/src/loading-indicator.ts",
+                content:
+`
+export interface Bar {
+    prop: number;
+}
+const bar: Bar = {
+    prop: 1
+}
+`
+            },
+        ];
+        const host = createServerHost(files);
+        const session = createSession(host, { logger: createLoggerWithInMemoryLogs(host) });
+        // Open files in the two configured projects
+        session.executeCommandSeq<protocol.UpdateOpenRequest>({
+            command: protocol.CommandTypes.UpdateOpen,
+            arguments: {
+                openFiles: [
+                    {
+                        file: files[1].path, // babel-loader/src/index.ts
+                        fileContent: files[1].content,
+                    }
+                ]
+            }
+        });
+        session.executeCommandSeq<protocol.UpdateOpenRequest>({
+            command: protocol.CommandTypes.UpdateOpen,
+            arguments: {
+                openFiles: [
+                    {
+                        file: files[3].path, // core/src/index.ts
+                        fileContent: files[3].content,
+                    }
+                ]
+            }
+        });
+        // Now change `babel-loader` project to no longer import `core` project
+        session.executeCommandSeq<protocol.UpdateOpenRequest>({
+            command: protocol.CommandTypes.UpdateOpen,
+            arguments: {
+                changedFiles: [
+                    {
+                        fileName: files[1].path,
+                        textChanges: [
+                            {
+                                start: {
+                                    line: 1,
+                                    offset: 26
+                                },
+                                end: {
+                                    line: 1,
+                                    offset: 26
+                                },
+                                newText: "// comment",
+                            }
+                        ]
+                    }
+                ]
+            }
+        });
+        const loadingIndicatorScriptInfo = session.getProjectService().getScriptInfo(files[3].path)!;
+        // At this point, we haven't updated `babel-loader` project yet,
+        // so `babel-loader` is still a containing project of `loading-indicator` file.
+        assert(loadingIndicatorScriptInfo.containingProjects.find(p => p.projectName === "/packages/babel-loader/tsconfig.json"));
+        // When calling find all references,
+        // we shouldn't crash due to using outdated information on a file's containig projects.
+        session.executeCommandSeq<protocol.ReferencesRequest>({
+            command: protocol.CommandTypes.References,
+            arguments: {
+                file: files[3].path, // core/src/index.ts
+                line: 5,             // `prop`
+                offset: 5,
+            }
+        });
+        baselineTsserverLogs("findAllReferences", "does not try to open a file in a project that was updated and no longer has the file", session);
+    });
+});