Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit c534375

Browse files
vmxAlan Shaw
authored and
Alan Shaw
committed
chore: remove ipld formats re-export (#872)
Prior to this change the `ipld-dag-cbor` and `ipld-dag-pb` modules are re-exported so that can be accessed within the Browser bundle. Those modules normally don't need to be used directly, they are kind of implementation details of IPLD. Hence remove them. BREAKING CHANGE: remove `types.dagCBOR` and `types.dagPB` from public API If you need the `ipld-dag-cbor` or `ipld-dag-pb` module in the Browser, you need to bundle them yourself.
1 parent ef49e95 commit c534375

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

Diff for: src/types.js

-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
'use strict'
22

33
const CID = require('cids')
4-
const dagCBOR = require('ipld-dag-cbor')
5-
const dagPB = require('ipld-dag-pb')
64
const multiaddr = require('multiaddr')
75
const multibase = require('multibase')
86
const multihash = require('multihashes')
@@ -12,8 +10,6 @@ const PeerInfo = require('peer-info')
1210
module.exports = () => ({
1311
Buffer: Buffer,
1412
CID: CID,
15-
dagPB: dagPB,
16-
dagCBOR: dagCBOR,
1713
multiaddr: multiaddr,
1814
multibase: multibase,
1915
multihash: multihash,

Diff for: test/types.spec.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33

44
const PeerId = require('peer-id')
55
const PeerInfo = require('peer-info')
6-
const dagCBOR = require('ipld-dag-cbor')
7-
const dagPB = require('ipld-dag-pb')
86
const multiaddr = require('multiaddr')
97
const multibase = require('multibase')
108
const multihash = require('multihashes')
@@ -47,9 +45,7 @@ describe('.types', function () {
4745
multiaddr: multiaddr,
4846
multibase: multibase,
4947
multihash: multihash,
50-
CID: CID,
51-
dagPB: dagPB,
52-
dagCBOR: dagCBOR
48+
CID: CID
5349
})
5450
})
5551
})

0 commit comments

Comments
 (0)