fix: do not fail stop node if failed start node

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>

Author: alanshaw

Diff for: test/bitswap.spec.js

@@ -27,7 +27,10 @@ describe('.bitswap', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('.wantlist', (done) => {
     ipfs.bitswap.wantlist((err, res) => {

Diff for: test/commands.spec.js

@@ -25,7 +25,10 @@ describe('.commands', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('lists commands', (done) => {
     ipfs.commands((err, res) => {

Diff for: test/constructor.spec.js

@@ -35,7 +35,10 @@ describe('ipfs-api constructor tests', () => {
       })
     })
 
-    after((done) => ipfsd.stop(done))
+    after((done) => {
+      if (!ipfsd) return done()
+      ipfsd.stop(done)
+    })
 
     it('opts', (done) => {
       const splitted = apiAddr.split('/')

Diff for: test/diag.spec.js

@@ -28,7 +28,10 @@ describe('.diag', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   describe('Callback API', () => {
     // Disabled in go-ipfs 0.4.10

Diff for: test/files.spec.js

@@ -47,7 +47,10 @@ describe('.files (the MFS API part)', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('add file for testing', (done) => {
     ipfs.files.add(testfile, (err, res) => {

Diff for: test/get.spec.js

@@ -41,7 +41,10 @@ describe('.get (specific go-ipfs features)', function () {
     ], done)
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('no compression args', (done) => {
     ipfs.get(smallFile.cid, (err, files) => {

Diff for: test/key.spec.js

@@ -25,7 +25,10 @@ describe('.key', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   describe('Callback API', () => {
     describe('.gen', () => {

Diff for: test/log.spec.js

@@ -25,7 +25,10 @@ describe('.log', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('.log.tail', (done) => {
     const req = ipfs.log.tail((err, res) => {

Diff for: test/name.spec.js

@@ -62,8 +62,14 @@ describe('.name', () => {
 
   after((done) => {
     parallel([
-      (cb) => ipfsd.stop(cb),
-      (cb) => otherd.stop(cb)
+      (cb) => {
+        if (!ipfsd) return cb()
+        ipfsd.stop(cb)
+      },
+      (cb) => {
+        if (!otherd) return cb()
+        otherd.stop(cb)
+      }
     ], done)
   })
 

Diff for: test/ping.spec.js

@@ -60,8 +60,14 @@ describe('.ping', function () {
 
   after((done) => {
     parallel([
-      (cb) => ipfsd.stop(cb),
-      (cb) => otherd.stop(cb)
+      (cb) => {
+        if (!ipfsd) return cb()
+        ipfsd.stop(cb)
+      },
+      (cb) => {
+        if (!otherd) return cb()
+        otherd.stop(cb)
+      }
     ], done)
   })
 

Diff for: test/pubsub-in-browser.spec.js

@@ -55,7 +55,10 @@ describe('.pubsub is not supported in the browser, yet!', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   describe('everything errors', () => {
     describe('Callback API', () => {

Diff for: test/refs.spec.js

@@ -49,7 +49,10 @@ describe('.refs', function () {
     ], done)
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   const result = [
     {

Diff for: test/repo.spec.js

@@ -24,7 +24,10 @@ describe('.repo', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('.repo.gc', (done) => {
     ipfs.repo.gc((err, res) => {

Diff for: test/stats.spec.js

@@ -24,7 +24,10 @@ describe('stats', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('.stats.bitswap', (done) => {
     ipfs.stats.bitswap((err, res) => {

Diff for: test/types.spec.js

@@ -34,7 +34,10 @@ describe('.types', function () {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('types object', () => {
     expect(ipfs.types).to.be.deep.equal({

Diff for: test/util.spec.js

@@ -32,7 +32,10 @@ describe('.util', () => {
     })
   })
 
-  after((done) => ipfsd.stop(done))
+  after((done) => {
+    if (!ipfsd) return done()
+    ipfsd.stop(done)
+  })
 
   it('.streamAdd', (done) => {
     const tfpath = path.join(__dirname, '/fixtures/testfile.txt')