Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ipfs-inactive/interface-js-ipfs-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.78.0
Choose a base ref
...
head repository: ipfs-inactive/interface-js-ipfs-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.79.0
Choose a head ref
  • 5 commits
  • 6 files changed
  • 4 contributors

Commits on Oct 15, 2018

  1. chore: remove ipld formats re-export (#374) 

    Prior to this change the `ipld-dag-cbor` and `ipld-dag-pb` modules
are re-exported so that can be accessed within the Browser bundle.
Those modules normally don't need to be used directly, they are
kind of implementation details of IPLD. Hence remove them.

---

Re-exporting these types here effectively forces ipfs core implementation versions to follow versions of these packages. Their API is now our API. i.e. if dag-pb increments major, then ipfs has to also increment major even if the rest of the IPFS API has no breaking changes.

Keeping these in sync is also problematic - if we try to use an old dag-pb module with ipfs whose ipld has a newer dag-pb things can break. If at all, they should be exported from ipld and re-exported here, so that ipfs doesn't have to keep them in sync. However considering they should not be used directly for day-to-day operation I'm in agreement with them being removed.
    @vmx
    vmx authored and Alan Shaw committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    7a931c1 View commit details
    Browse the repository at this point in the history

  2. docs: add note about ipfs.types.Buffer (#373) 

    I've spent an hour trying to figure out how to do `ipfs add` in the browser: docs describe the "Buffer" part really vaguely and don't mention that `ipfs.files.add` in fact creates a directory object unless used with a correctly created buffer. It works with an incorrectly created buffer, but creates a directory with auto-generated name:

```js
let data = new Uint8Array([0x41, 0x42, 0x43]);
let results = await ipfs.files.add(data);
```

Here `results` is

```json
[
  {
    "path": "QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn",
    "hash": "QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn",
    "size": 4
  }
]
```

Now open this hash in `ipfs.io` and try to figure out wtf that is and why size is 4. The `ipfs.types.Buffer` was the key.
    @klueq
    klueq authored and Alan Shaw committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    e5d90e2 View commit details
    Browse the repository at this point in the history

  3. fix: dht find peer and providers (#368)

    @vasco-santos
    vasco-santos authored and Alan Shaw committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    40f796f View commit details
    Browse the repository at this point in the history

  4. chore: update contributors

    Alan Shaw committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    bf0e7b6 View commit details
    Browse the repository at this point in the history

  5. chore: release version v0.79.0

    Alan Shaw committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    59f30cd View commit details
    Browse the repository at this point in the history
Loading