Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit b9df5fb

Browse files
author
Alan Shaw
authored
fix: parents option and ls stream flow (#558)
1 parent 5d81341 commit b9df5fb

File tree

9 files changed

+18
-17
lines changed

9 files changed

+18
-17
lines changed

Diff for: ‎src/files-mfs/cp.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ module.exports = (createCommon, options) => {
4646
const testDir = `/test-${hat()}`
4747

4848
series([
49-
(cb) => ipfs.files.mkdir(testDir, { p: true }, cb),
49+
(cb) => ipfs.files.mkdir(testDir, { parents: true }, cb),
5050
(cb) => ipfs.files.write(`${testDir}/a`, Buffer.from('TEST'), { create: true }, cb),
5151
(cb) => ipfs.files.cp(`${testDir}/a`, `${testDir}/b`, cb)
5252
], (err) => {
@@ -68,7 +68,7 @@ module.exports = (createCommon, options) => {
6868
const testDir = `/test-${hat()}`
6969

7070
series([
71-
(cb) => ipfs.files.mkdir(`${testDir}/lv1/lv2`, { p: true }, cb),
71+
(cb) => ipfs.files.mkdir(`${testDir}/lv1/lv2`, { parents: true }, cb),
7272
(cb) => ipfs.files.cp(`${testDir}/lv1/lv2`, `${testDir}/lv1/lv3`, cb)
7373
], (err) => {
7474
expect(err).to.not.exist()

Diff for: ‎src/files-mfs/flush.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = (createCommon, options) => {
5252
const testDir = `/test-${hat()}`
5353

5454
series([
55-
(cb) => ipfs.files.mkdir(testDir, { p: true }, cb),
55+
(cb) => ipfs.files.mkdir(testDir, { parents: true }, cb),
5656
(cb) => ipfs.files.flush(testDir, cb)
5757
], (err) => {
5858
expect(err).to.not.exist()

Diff for: ‎src/files-mfs/ls-pull-stream.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = (createCommon, options) => {
5252
const testDir = `/test-${hat()}`
5353

5454
series([
55-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
55+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
5656
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
5757
], (err) => {
5858
expect(err).to.not.exist()
@@ -75,7 +75,7 @@ module.exports = (createCommon, options) => {
7575
const testDir = `/test-${hat()}`
7676

7777
series([
78-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
78+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
7979
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
8080
], (err) => {
8181
expect(err).to.not.exist()

Diff for: ‎src/files-mfs/ls-readable-stream.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ module.exports = (createCommon, options) => {
3636
const testDir = `/test-${hat()}`
3737

3838
const stream = ipfs.files.lsReadableStream(`${testDir}/404`)
39+
stream.on('data', () => {})
3940

4041
stream.once('error', (err) => {
4142
expect(err).to.exist()
@@ -48,7 +49,7 @@ module.exports = (createCommon, options) => {
4849
const testDir = `/test-${hat()}`
4950

5051
series([
51-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
52+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
5253
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
5354
], (err) => {
5455
expect(err).to.not.exist()
@@ -72,7 +73,7 @@ module.exports = (createCommon, options) => {
7273
const testDir = `/test-${hat()}`
7374

7475
series([
75-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
76+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
7677
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
7778
], (err) => {
7879
expect(err).to.not.exist()

Diff for: ‎src/files-mfs/ls.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ module.exports = (createCommon, options) => {
4747
const testDir = `/test-${hat()}`
4848

4949
series([
50-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
50+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
5151
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
5252
], (err) => {
5353
expect(err).to.not.exist()
@@ -67,7 +67,7 @@ module.exports = (createCommon, options) => {
6767
const testDir = `/test-${hat()}`
6868

6969
series([
70-
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { p: true }, cb),
70+
(cb) => ipfs.files.mkdir(`${testDir}/lv1`, { parents: true }, cb),
7171
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
7272
], (err) => {
7373
expect(err).to.not.exist()

Diff for: ‎src/files-mfs/mkdir.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ module.exports = (createCommon, options) => {
4343
it('should make directory and its parents', (done) => {
4444
const testDir = `/test-${hat()}`
4545

46-
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { p: true }, (err) => {
46+
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { parents: true }, (err) => {
4747
expect(err).to.not.exist()
4848
done()
4949
})

Diff for: ‎src/files-mfs/mv.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ module.exports = (createCommon, options) => {
3232

3333
before((done) => {
3434
series([
35-
(cb) => ipfs.files.mkdir('/test/lv1/lv2', { p: true }, cb),
35+
(cb) => ipfs.files.mkdir('/test/lv1/lv2', { parents: true }, cb),
3636
(cb) => ipfs.files.write('/test/a', Buffer.from('Hello, world!'), { create: true }, cb)
3737
], done)
3838
})
@@ -52,7 +52,7 @@ module.exports = (createCommon, options) => {
5252
const testDir = `/test-${hat()}`
5353

5454
series([
55-
(cb) => ipfs.files.mkdir(`${testDir}/lv1/lv2`, { p: true }, cb),
55+
(cb) => ipfs.files.mkdir(`${testDir}/lv1/lv2`, { parents: true }, cb),
5656
(cb) => ipfs.files.write(`${testDir}/a`, Buffer.from('Hello, world!'), { create: true }, cb)
5757
], (err) => {
5858
expect(err).to.not.exist()
@@ -67,7 +67,7 @@ module.exports = (createCommon, options) => {
6767
it('should move dir, expect no error', (done) => {
6868
const testDir = `/test-${hat()}`
6969

70-
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { p: true }, (err) => {
70+
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { parents: true }, (err) => {
7171
expect(err).to.not.exist()
7272

7373
ipfs.files.mv('/test/lv1/lv2', '/test/lv1/lv4', (err) => {

Diff for: ‎src/files-mfs/rm.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ module.exports = (createCommon, options) => {
4545
const testDir = `/test-${hat()}`
4646

4747
series([
48-
(cb) => ipfs.files.mkdir(testDir, { p: true }, cb),
48+
(cb) => ipfs.files.mkdir(testDir, { parents: true }, cb),
4949
(cb) => ipfs.files.write(`${testDir}/c`, Buffer.from('Hello, world!'), { create: true }, cb)
5050
], (err) => {
5151
expect(err).to.not.exist()
@@ -60,7 +60,7 @@ module.exports = (createCommon, options) => {
6060
it('should remove dir, expect no error', (done) => {
6161
const testDir = `/test-${hat()}`
6262

63-
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { p: true }, (err) => {
63+
ipfs.files.mkdir(`${testDir}/lv1/lv2`, { parents: true }, (err) => {
6464
expect(err).to.not.exist()
6565

6666
ipfs.files.rm(`${testDir}/lv1/lv2`, { recursive: true }, (err) => {

Diff for: ‎src/files-mfs/stat.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module.exports = (createCommon, options) => {
4848
const testDir = `/test-${hat()}`
4949

5050
series([
51-
(cb) => ipfs.files.mkdir(testDir, { p: true }, cb),
51+
(cb) => ipfs.files.mkdir(testDir, { parents: true }, cb),
5252
(cb) => ipfs.files.write(`${testDir}/b`, Buffer.from('Hello, world!'), { create: true }, cb)
5353
], (err) => {
5454
expect(err).to.not.exist()
@@ -74,7 +74,7 @@ module.exports = (createCommon, options) => {
7474
const testDir = `/test-${hat()}`
7575

7676
series([
77-
(cb) => ipfs.files.mkdir(testDir, { p: true }, cb),
77+
(cb) => ipfs.files.mkdir(testDir, { parents: true }, cb),
7878
(cb) => ipfs.files.write(`${testDir}/a`, Buffer.from('Hello, world!'), { create: true }, cb)
7979
], (err) => {
8080
expect(err).to.not.exist()

0 commit comments

Comments
 (0)