Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 531f9ac

Browse files
author
Alan Shaw
committed
refactor: use promise-nodeify
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
1 parent 3a0fe8a commit 531f9ac

File tree

3 files changed

+39
-23
lines changed

3 files changed

+39
-23
lines changed

Diff for: package.json

+1
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
"once": "^1.4.0",
7474
"peer-id": "~0.12.2",
7575
"peer-info": "~0.15.1",
76+
"promise-nodeify": "^3.0.1",
7677
"promisify-es6": "^1.0.3",
7778
"pull-defer": "~0.2.3",
7879
"pull-stream": "^3.6.9",

Diff for: src/lib/callbackify.js

-17
This file was deleted.

Diff for: src/pubsub/index.js

+38-6
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,50 @@
11
'use strict'
22

3-
const callbackify = require('../lib/callbackify')
3+
const nodeify = require('promise-nodeify')
44

55
// This file is temporary and for compatibility with legacy usage
66
module.exports = (send, options) => {
77
if (typeof send !== 'function') {
88
options = send
99
}
1010

11+
const ls = require('./ls')(options)
12+
const peers = require('./peers')(options)
13+
const publish = require('./publish')(options)
14+
const subscribe = require('./subscribe')(options)
15+
const unsubscribe = require('./unsubscribe')(options)
16+
1117
return {
12-
ls: callbackify(require('./ls')(options)),
13-
peers: callbackify(require('./peers')(options)),
14-
publish: callbackify(require('./publish')(options)),
15-
subscribe: callbackify(require('./subscribe')(options), { minArgs: 2 }),
16-
unsubscribe: callbackify(require('./unsubscribe')(options), { minArgs: 2 })
18+
ls: (options, callback) => {
19+
if (typeof options === 'function') {
20+
callback = options
21+
options = {}
22+
}
23+
return nodeify(ls(options), callback)
24+
},
25+
peers: (topic, options, callback) => {
26+
if (typeof options === 'function') {
27+
callback = options
28+
options = {}
29+
}
30+
return nodeify(peers(topic, options), callback)
31+
},
32+
publish: (topic, data, options, callback) => {
33+
if (typeof options === 'function') {
34+
callback = options
35+
options = {}
36+
}
37+
return nodeify(publish(topic, data, options), callback)
38+
},
39+
subscribe: (topic, handler, options, callback) => {
40+
if (typeof options === 'function') {
41+
callback = options
42+
options = {}
43+
}
44+
return nodeify(subscribe(topic, handler, options), callback)
45+
},
46+
unsubscribe: (topic, handler, callback) => {
47+
return nodeify(unsubscribe(topic, handler), callback)
48+
}
1749
}
1850
}

0 commit comments

Comments
 (0)