From bfdda8a8a83a2206c3889fb6559c6acc0e6aa0c4 Mon Sep 17 00:00:00 2001 From: Pascal Precht Date: Tue, 7 Aug 2018 15:57:22 +0200 Subject: [PATCH 1/4] fix(spec/dag): fix wrong example output for sha3-512 hash algorithm (#347) Closes #307 License: MIT Signed-off-by: Pascal Precht --- SPEC/DAG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SPEC/DAG.md b/SPEC/DAG.md index b6cb0c03..63ce0c24 100644 --- a/SPEC/DAG.md +++ b/SPEC/DAG.md @@ -36,7 +36,7 @@ const obj = { simple: 'object' } ipfs.dag.put(obj, { format: 'dag-cbor', hashAlg: 'sha3-512' }, (err, cid) => { console.log(cid.toBaseEncodedString()) - // zdpuAzE1oAAMpsfdoexcJv6PmL9UhE8nddUYGU32R98tzV5fv + // zBwWX9ecx5F4X54WAjmFLErnBT6ByfNxStr5ovowTL7AhaUR98RWvXPS1V3HqV1qs3r5Ec5ocv7eCdbqYQREXNUfYNuKG }) ``` From a173a4284a449f3f4d0689896b4ae4aa84836460 Mon Sep 17 00:00:00 2001 From: Alex Potsides Date: Thu, 9 Aug 2018 09:26:17 +0100 Subject: [PATCH 2/4] fix: update error messages in line with go (#348) Js says 'file did not exist', go says 'file does not exist'. --- js/src/files/read-readable-stream.js | 2 +- js/src/files/read.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/src/files/read-readable-stream.js b/js/src/files/read-readable-stream.js index e9a6430e..d31d8fd6 100644 --- a/js/src/files/read-readable-stream.js +++ b/js/src/files/read-readable-stream.js @@ -38,7 +38,7 @@ module.exports = (createCommon, options) => { const stream = ipfs.files.readReadableStream(`${testDir}/404`) - stream.on('error', (err) => { + stream.once('error', (err) => { expect(err).to.exist() expect(err.message).to.contain('does not exist') done() diff --git a/js/src/files/read.js b/js/src/files/read.js index ac1eb8ff..5cdea9f2 100644 --- a/js/src/files/read.js +++ b/js/src/files/read.js @@ -35,9 +35,9 @@ module.exports = (createCommon, options) => { it('should not read not found, expect error', (done) => { const testDir = `/test-${hat()}` - ipfs.files.read(`${testDir}/404`, (err, buf) => { + ipfs.files.read(`${testDir}/404`, (err) => { expect(err).to.exist() - expect(buf).to.not.exist() + expect(err.message).to.contain('does not exist') done() }) }) From de8b5b4e55035cb2b55baca1da3c086cf9a5ccbb Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Thu, 9 Aug 2018 10:26:13 +0100 Subject: [PATCH 3/4] chore: update contributors From a0559e7f47f3989fafa3221dae78d94ea17e07a3 Mon Sep 17 00:00:00 2001 From: Alan Shaw Date: Thu, 9 Aug 2018 10:26:14 +0100 Subject: [PATCH 4/4] chore: release version v0.75.2 --- CHANGELOG.md | 11 +++++++++++ package.json | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6afa263d..87b569d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,14 @@ + +## [0.75.2](https://github.com/ipfs/interface-ipfs-core/compare/v0.75.1...v0.75.2) (2018-08-09) + + +### Bug Fixes + +* **spec/dag:** fix wrong example output for sha3-512 hash algorithm ([#347](https://github.com/ipfs/interface-ipfs-core/issues/347)) ([bfdda8a](https://github.com/ipfs/interface-ipfs-core/commit/bfdda8a)), closes [#307](https://github.com/ipfs/interface-ipfs-core/issues/307) +* update error messages in line with go ([#348](https://github.com/ipfs/interface-ipfs-core/issues/348)) ([a173a42](https://github.com/ipfs/interface-ipfs-core/commit/a173a42)) + + + ## [0.75.1](https://github.com/ipfs/interface-ipfs-core/compare/v0.75.0...v0.75.1) (2018-08-06) diff --git a/package.json b/package.json index 9633c75f..da440985 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "interface-ipfs-core", - "version": "0.75.1", + "version": "0.75.2", "description": "A test suite and interface you can use to implement a IPFS core interface.", "leadMaintainer": "Alan Shaw ", "main": "js/src/index.js",