Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 1aa0382

Browse files
vmxdaviddias
authored andcommitted
Fixes based on review (fixup this commit before the merge)
1 parent 7a6fc5f commit 1aa0382

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

js/src/dag.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,13 @@ module.exports = (common) => {
9494
}, done)
9595
})
9696

97-
// This works because dag-pb will serialize any object. If the object
98-
// has neither a `data` nor `links` field it's serialized as an empty
99-
// object
100-
it.skip('dag-cbor node with wrong multicodec', (done) => {
97+
it('dag-cbor node with wrong multicodec', function (done) {
98+
// This works in go-ipfs because dag-pb will serialize any object. If
99+
// the object has neither a `data` nor `links` field it's serialized
100+
// as an empty object
101+
if (withGo) {
102+
this.skip()
103+
}
101104
ipfs.dag.put(cborNode, {
102105
format: 'dag-pb',
103106
hashAlg: 'sha3-512'
@@ -252,7 +255,6 @@ module.exports = (common) => {
252255
}
253256
ipfs.dag.get(cidPb, 'Data', (err, result) => {
254257
expect(err).to.not.exist()
255-
console.log('vmx: result', result.value)
256258
expect(result.value.data).to.eql(Buffer.from('I am inside a Protobuf'))
257259
done()
258260
})

0 commit comments

Comments
 (0)