fix(native): remove ionic-native dependencies, use raw cordova calls. #190

Author: mlynch

package.json

@@ -28,9 +28,7 @@
   "typings": "dist/es5/index.d.ts",
   "module": "dist/esm/index.js",
   "dependencies": {
-    "ionic-native": "^2.2.11",
-    "superagent": "1.7.2",
-    "@ionic/db": "^0.1.0"
+    "superagent": "1.7.2"
   },
   "devDependencies": {
     "babel-plugin-external-helpers": "^6.8.0",
@@ -75,7 +73,6 @@
     "minify": "uglifyjs --compress --mangle --screw-ie8 --source-map dist/bundle/ionic.cloud.min.js.map -o dist/bundle/ionic.cloud.min.js -p relative -- dist/bundle/ionic.cloud.js",
     "build": "npm run lint && npm run tsc && npm run rollup && npm run version && npm run minify",
     "test": "karma start --singleRun",
-    "prepublish": "npm run build",
     "docs": "node scripts/docs.js",
     "watch": "scripts/watch.sh"
   }

src/auth.ts

@@ -1,5 +1,3 @@
-import { Facebook, FacebookLoginResponse, GooglePlus } from 'ionic-native';
-
 import {
   APIResponseErrorDetails,
   AuthDependencies,
@@ -641,7 +639,7 @@ export class GoogleAuth extends NativeAuth implements IGoogleAuth {
     user.unstore();
     user.clear();
 
-    GooglePlus.logout().then( () => {
+    window.plugins.googleplus.logout(() => {
       deferred.resolve();
     }, (err) => {
       deferred.reject(err);
@@ -657,18 +655,13 @@ export class GoogleAuth extends NativeAuth implements IGoogleAuth {
     this.emitter.once('cordova:deviceready', () => {
       let scope = ['profile', 'email'];
 
-      if (!GooglePlus) {
-        deferred.reject(new Error('Ionic native is not installed'));
-        return;
-      }
-
       if (!window || !window.cordova) {
         deferred.reject(new Error('Cordova is missing'));
         return;
       }
 
       if (!window.plugins || !window.plugins.googleplus) {
-        deferred.reject(new Error('GooglePlus cordova plugin is missing.'));
+        deferred.reject(new Error('GooglePlus cordova plugin is missing. Install the plugin by following the instructions here: https://github.com/EddyVerbruggen/cordova-plugin-googleplus'));
         return;
       }
 
@@ -685,7 +678,7 @@ export class GoogleAuth extends NativeAuth implements IGoogleAuth {
         });
       }
 
-      GooglePlus.login({'webClientId': authConfig.google.webClientId, 'offline': true, 'scopes': scope.join(' ')}).then((success) => {
+      window.plugins.googleplus.login({'webClientId': authConfig.google.webClientId, 'offline': true, 'scopes': scope.join(' ')}, (success) => {
         if (!success.serverAuthCode) {
           deferred.reject(new Error('Failed to retrieve offline access token.'));
           return;
@@ -738,7 +731,8 @@ export class FacebookAuth extends NativeAuth implements IFacebookAuth {
     user.clear();
 
     // Clear the facebook auth.
-    Facebook.logout().then( () => {
+
+    window.facebookConnectPlugin.logout(() => {
       deferred.resolve();
     }, (err) => {
       deferred.reject(err);
@@ -761,11 +755,6 @@ export class FacebookAuth extends NativeAuth implements IFacebookAuth {
     }
 
     this.emitter.once('cordova:deviceready', () => {
-      if (!Facebook) {
-        deferred.reject(new Error('Ionic native is not installed'));
-        return;
-      }
-
       if (!window || !window.cordova) {
         deferred.reject(new Error('Cordova is missing.'));
         return;
@@ -776,7 +765,7 @@ export class FacebookAuth extends NativeAuth implements IFacebookAuth {
         return;
       }
 
-      Facebook.login(scope).then((r: FacebookLoginResponse) => {
+      window.facebookConnectPlugin.login(scope, (r: any) => {
         scope.splice(scope.indexOf('public_profile'), 1);
         const request_object = {
           'app_id': this.config.get('app_id'),

src/definitions.ts

@@ -1,5 +1,3 @@
-import { Device as NativeDevice } from 'ionic-native';
-
 /**
  * @hidden
  */
@@ -277,15 +275,15 @@ export interface DeviceIsConnectedToNetworkOptions {
  * @hidden
  */
 export interface DeviceDependencies {
-  nativeDevice: typeof NativeDevice;
+  nativeDevice: any;
   emitter: IEventEmitter;
 }
 
 /**
  * @hidden
  */
 export interface IDevice {
-  native: typeof NativeDevice;
+  native: any;
   type: string;
 
   isAndroid(): boolean;
@@ -821,7 +819,7 @@ export interface AuthDependencies {
 }
 
 /**
- * @hidden 
+ * @hidden
  */
 export interface NativeAuthDependencies {
   config: IConfig;

src/device.ts

@@ -1,5 +1,3 @@
-import { Device as NativeDevice } from 'ionic-native';
-
 import {
   DeviceDependencies,
   DeviceIsConnectedToNetworkOptions,
@@ -15,7 +13,7 @@ declare var navigator: any;
  */
 export class Device implements IDevice {
 
-  public native: typeof NativeDevice;
+  public native: any;
 
   public type: string;
 

src/di.ts

@@ -1,5 +1,3 @@
-import { Device as NativeDevice } from 'ionic-native';
-
 import {
   AppStatus,
   IAuth,
@@ -163,7 +161,8 @@ export class Container {
 
   @cache
   public get device(): IDevice {
-    return new Device({'nativeDevice': NativeDevice, 'emitter': this.eventEmitter});
+    const cordovaDevice = (window as any).device;
+    return new Device({'nativeDevice': cordovaDevice, 'emitter': this.eventEmitter});
   }
 
   @cache

tsconfig-es5.json

@@ -13,7 +13,7 @@
         "pretty": true,
         "removeComments": false,
         "sourceMap": true,
-        "strictNullChecks": true,
+        "strictNullChecks": false,
         "target": "es5"
     },
     "files": [

tsconfig-esm.json

@@ -10,7 +10,7 @@
         "noImplicitReturns": true,
         "outDir": "dist/esm",
         "removeComments": false,
-        "strictNullChecks": true,
+        "strictNullChecks": false,
         "target": "es5"
     },
     "files": [