Skip to content

Commit f1d136f

Browse files
matteodanellimikehardymobileteo
authored
fix(android): remove jcenter repository completely (hieuvp#202)
* build(deps): update npm package-lock files * build(deps): use androidx.biometric 1.1.0 * chore(android): removed completely jCenter * build(deps): npm is used in repo currently, not yarn * fix(example, android): fix app name so `yarn react-native run-android` works the app name in manifest was different then the configured app name, so the app did not run from the command line, now it does * build(deps): revert partial react-native version bump you cannot just bump the version without actually doing all the changes required when you update react-native (e.g., integrating diffs from upgrade-helper) the partial change broke the example app on ios, reverting it makes the example app work again, at least up through use of Xcode-12.4. react-native 0.60 does not work with Xcode 12.5+ but that's a known issue and is solved by doing a full update of the example app, which is out of scope for a jcenter change Co-authored-by: Mike Hardy <github@mikehardy.net> Co-authored-by: Matteo Danelli <matteo.danelli@docebo.com>
1 parent 31f160f commit f1d136f

File tree

7 files changed

+23845
-2353
lines changed

7 files changed

+23845
-2353
lines changed

android/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ android {
3737

3838
repositories {
3939
mavenCentral()
40-
jcenter()
40+
maven { url 'https://jitpack.io' }
4141
}
4242

4343
dependencies {
4444
implementation 'com.facebook.react:react-native:+'
4545
// androidx:biometric now supports fingerprint back to Android v23
46-
implementation "androidx.biometric:biometric:1.0.1"
46+
implementation "androidx.biometric:biometric:1.1.0"
4747

4848
// retain fingerprintScanner lib for compat with Android v16-23 device-specific drivers (Samsung & MeiZu)
4949
// 1.2.3 is the minimum version compatible with androidx.

examples/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ android {
129129
}
130130

131131
defaultConfig {
132-
applicationId "com.example.fingerprintscannerexample"
132+
applicationId "com.examples"
133133
minSdkVersion rootProject.ext.minSdkVersion
134134
targetSdkVersion rootProject.ext.targetSdkVersion
135135
versionCode 1

examples/android/build.gradle

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ buildscript {
1010
}
1111
repositories {
1212
google()
13-
jcenter()
14-
maven {
15-
url 'https://maven.google.com/'
16-
name 'Google'
17-
}
13+
mavenCentral()
1814
}
1915
dependencies {
2016
classpath("com.android.tools.build:gradle:3.4.1")
@@ -36,6 +32,7 @@ allprojects {
3632
url("$rootDir/../node_modules/jsc-android/dist")
3733
}
3834
google()
39-
jcenter()
35+
mavenCentral()
36+
maven { url 'https://jitpack.io' }
4037
}
4138
}

examples/android/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ android.useAndroidX=true
2121
android.enableJetifier=true
2222

2323
# Version of flipper SDK to use with React Native
24-
FLIPPER_VERSION=0.54.0
24+
FLIPPER_VERSION=0.101.0

examples/ios/Podfile.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ PODS:
5757
- React-cxxreact (= 0.60.0)
5858
- React-jsi (= 0.60.0)
5959
- React-jsinspector (0.60.0)
60-
- react-native-fingerprint-scanner (2.6.1):
60+
- react-native-fingerprint-scanner (6.0.0):
6161
- React
6262
- React-RCTActionSheet (0.60.0):
6363
- React-Core (= 0.60.0)
@@ -97,7 +97,7 @@ DEPENDENCIES:
9797
- React-jsi (from `../node_modules/react-native/ReactCommon/jsi`)
9898
- React-jsiexecutor (from `../node_modules/react-native/ReactCommon/jsiexecutor`)
9999
- React-jsinspector (from `../node_modules/react-native/ReactCommon/jsinspector`)
100-
- react-native-fingerprint-scanner (from `/Users/phillip/Development/react-native-fingerprint-scanner`)
100+
- react-native-fingerprint-scanner (from `../..`)
101101
- React-RCTActionSheet (from `../node_modules/react-native/Libraries/ActionSheetIOS`)
102102
- React-RCTAnimation (from `../node_modules/react-native/Libraries/NativeAnimation`)
103103
- React-RCTBlob (from `../node_modules/react-native/Libraries/Blob`)
@@ -111,7 +111,7 @@ DEPENDENCIES:
111111
- yoga (from `../node_modules/react-native/ReactCommon/yoga`)
112112

113113
SPEC REPOS:
114-
https://github.com/cocoapods/specs.git:
114+
trunk:
115115
- boost-for-react-native
116116

117117
EXTERNAL SOURCES:
@@ -138,7 +138,7 @@ EXTERNAL SOURCES:
138138
React-jsinspector:
139139
:path: "../node_modules/react-native/ReactCommon/jsinspector"
140140
react-native-fingerprint-scanner:
141-
:path: "/Users/phillip/Development/react-native-fingerprint-scanner"
141+
:path: "../.."
142142
React-RCTActionSheet:
143143
:path: "../node_modules/react-native/Libraries/ActionSheetIOS"
144144
React-RCTAnimation:
@@ -175,7 +175,7 @@ SPEC CHECKSUMS:
175175
React-jsi: 8e128c4d0d8febc2977ef617d1c09bb54326069c
176176
React-jsiexecutor: 7a3554f703a58963ec80b860144ea0f0e9b910e1
177177
React-jsinspector: d4ed52225912efe0019bb7f1a225aec20f23049a
178-
react-native-fingerprint-scanner: ab4321df8bc1c490da412d05ad39bfc00fb29ea5
178+
react-native-fingerprint-scanner: ac6656f18c8e45a7459302b84da41a44ad96dbbe
179179
React-RCTActionSheet: b27ff3cf3a68f917c46d2b94abf938b625b96570
180180
React-RCTAnimation: 9e4708e5bd65fca8285ce7c0aa076f3f4fa5c2f8
181181
React-RCTBlob: 6eafcc3a24f33785692a7be24918ade607bc8719
@@ -190,4 +190,4 @@ SPEC CHECKSUMS:
190190

191191
PODFILE CHECKSUM: 593715dded8bf0be25016da035dba44a463c1886
192192

193-
COCOAPODS: 1.7.3
193+
COCOAPODS: 1.11.2

0 commit comments

Comments
 (0)