-
Notifications
You must be signed in to change notification settings - Fork 9
Comparing changes
Open a pull request
base repository: inspera/blackbricks
base: 1.0.1
head repository: inspera/blackbricks
compare: 1.0.5
- 13 commits
- 6 files changed
- 3 contributors
Commits on Dec 9, 2022
-
chore(deps): bump certifi from 2022.6.15.1 to 2022.12.7
Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.6.15.1 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.06.15.1...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for f4c2f9f - Browse repository at this point
Copy the full SHA f4c2f9fView commit details
Commits on Jan 9, 2023
-
Bugix in _format_sql_cell in handling # MAGIC %sql
This bugfix fixes the issue when %sql is not on a separate line. OLD: - Resulting SQL cell is wrong, when %sql is not on a separate line - %sql is followed by SPACE/TAB + "first line of the SQL query" - Example: - %sql SELECT current_date - Sometimes an additional (empty) line is added after %sql. But not always! OLD: - Resulting SQL cell is correct, when %sql is not on a separate line - Example: - %sql SELECT current_date - it doesn't matter if a SPACE or TAB follows %sql - exactly 1 additional (empty) line is added after %sql. Always! - in addition the list magics[] has been removed from the code. It's not used. Signed-off-by: Dejan.Hrubenja<dejan.hrubenja@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for 8d8df37 - Browse repository at this point
Copy the full SHA 8d8df37View commit details -
Test cases for SQL formatting added
Added test cases to test some weird cases, when: - MAGIC %sql is not on a separate line (Databricks allows this) - MAGIC %sql is followed by 0/1/multiple NewLines The result has to be deterministic always: - If Databricks accepts (the first line of) the SQL query behind "# MAGIC %sql", we have to accept this too! - It doesn't matter if %sql is followed by: - SPACE - TAB - exactly 1 NewLine - multiple NewLines ... The result has to be deterministic! - 1st line: # MAGIC %sql - 2nd line: # - 3rd line: # First-line-of-sqlparse-Output - ... Signed-off-by: Dejan.Hrubenja<dejan.hrubenja@mercedes-benz.com>
Configuration menu - View commit details
-
Copy full SHA for f0d20da - Browse repository at this point
Copy the full SHA f0d20daView commit details
Commits on Jan 10, 2023
-
Merge pull request #30 from inspera/dependabot/pip/certifi-2022.12.7
chore(deps): bump certifi from 2022.6.15.1 to 2022.12.7
Configuration menu - View commit details
-
Copy full SHA for fac0d53 - Browse repository at this point
Copy the full SHA fac0d53View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5c0378 - Browse repository at this point
Copy the full SHA c5c0378View commit details
Commits on Jan 30, 2023
-
normalize newlines and edit test notebook
I'd like to move towards having the same SQL formatting applied by blackbricks as what you get by using "Format SQL" in the Databricks notebook UI. It removes any leading or trailing newlines, which this commit now ensures. It keeps your fix for the actual bug where blackbricks would drop code on the same line as the %sql. I've edited the test notebook too, as it is meant to hold pre-formatted code. The test checks that blackbricks does _not_ alter this file. While what @de-hru added are valid and good test cases, something else is required to add test with notebooks that _should_ change. Blackbricks has a longstanding need for a better testing harness, but thats a separate issue which shouldn't be addressed as part of #32.
Configuration menu - View commit details
-
Copy full SHA for 5487953 - Browse repository at this point
Copy the full SHA 5487953View commit details
Commits on Jan 31, 2023
-
Merge pull request #32 from mercedes-benz/fix-handling-of-magic-sql-i…
…n-sql-cells Fix handling of magic sql in sql cells
Configuration menu - View commit details
-
Copy full SHA for e98aa91 - Browse repository at this point
Copy the full SHA e98aa91View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4c4381 - Browse repository at this point
Copy the full SHA d4c4381View commit details -
fix: avoid failing on quoted cell dividers
This fixes a bug where any code with the `# COMMAND ------` cell divisor comment would cause parse errors or unwanted cell splits. Example: ```python print("""\n# COMMAND ----------""") ```` This would fail on versions <=1.0.3 Now only lines containing only this cell divisor (disregarding trailing whitespace) will be treated as cell divisors.
Configuration menu - View commit details
-
Copy full SHA for f343636 - Browse repository at this point
Copy the full SHA f343636View commit details -
Merge pull request #33 from inspera/improved-cell-detection
fix: avoid failing on quoted cell dividers
Configuration menu - View commit details
-
Copy full SHA for b993ef9 - Browse repository at this point
Copy the full SHA b993ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e99e854 - Browse repository at this point
Copy the full SHA e99e854View commit details
Commits on Feb 7, 2023
-
fix(deps): bump oauthlib from 3.2.1 to 3.2.2 (#35)
Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/oauthlib/oauthlib/releases) - [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst) - [Commits](oauthlib/oauthlib@v3.2.1...v3.2.2) --- updated-dependencies: - dependency-name: oauthlib dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b5cb6ad - Browse repository at this point
Copy the full SHA b5cb6adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cd9989 - Browse repository at this point
Copy the full SHA 5cd9989View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.0.1...1.0.5