Fix bug in componentShouldUpdate causing the component never to update when children are strings and have changed (#16)

yn5 · frostney · commit 92eb966485d4 · 2016-05-14T15:18:24.000+02:00
diff --git a/src/components/TypeWriter.jsx b/src/components/TypeWriter.jsx
@@ -39,7 +39,7 @@ class TypeWriter extends React.Component {
   }
 
   shouldComponentUpdate(nextProps, nextState) {
-    const children = this.props;
+    const { children } = this.props;
     const nextChildren = nextProps.children;
     const childrenAreStrings = typeof children === 'string' && typeof nextChildren === 'string';
     // TODO Implement childrenChanged for non-string children as well

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class TypeWriter extends React.Component {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`shouldComponentUpdate(nextProps, nextState) {`
`42`		`- const children = this.props;`
	`42`	`+ const { children } = this.props;`
`43`	`43`	`const nextChildren = nextProps.children;`
`44`	`44`	`const childrenAreStrings = typeof children === 'string' && typeof nextChildren === 'string';`
`45`	`45`	`// TODO Implement childrenChanged for non-string children as well`