Skip to content

Commit d1e3df0

Browse files
Removed HorizontalSwipeRightInteractionController
This logic has been folded into HorizontalSwipeInteractionController, where left / right behaviour is controlled via a boolean property.
1 parent 78cf23f commit d1e3df0

File tree

6 files changed

+11
-146
lines changed

6 files changed

+11
-146
lines changed

InteractionControllers/CEHorizontalSwipeInteractionController.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,16 @@
1010
#import "CEBaseInteractionController.h"
1111

1212
/**
13-
A horizontal swipe interaction controller. When used with a navigation controller, a right-to-left swipe
13+
A horizontal swipe interaction controller. When used with a navigation controller, a right-to-left, or left-to-right swipe
1414
will cause a 'pop' navigation. When used wth a tabbar controller, right-to-left and left-to-right cause navigation
1515
between neighbouring tabs.
1616
*/
1717
@interface CEHorizontalSwipeInteractionController : CEBaseInteractionController
1818

19+
/**
20+
Indicates whether a navigation controller 'pop' should occur on a right-to-left, or a left-to-right
21+
swipe. This property does not affect tab controller or modal interactions.
22+
*/
23+
@property (nonatomic) BOOL popOnRightToLeft;
24+
1925
@end

InteractionControllers/CEHorizontalSwipeInteractionController.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ -(void)dealloc {
2020
}
2121

2222
- (void)wireToViewController:(UIViewController *)viewController forOperation:(CEInteractionOperation)operation{
23+
self.popOnRightToLeft = YES;
2324
_operation = operation;
2425
_viewController = viewController;
2526
[self prepareGestureRecognizerInView:viewController.view];
@@ -49,7 +50,8 @@ - (void)handleGesture:(UIPanGestureRecognizer*)gestureRecognizer {
4950

5051
if (_operation == CEInteractionOperationPop) {
5152
// for pop operation, fire on right-to-left
52-
if (rightToLeftSwipe) {
53+
if ((self.popOnRightToLeft && rightToLeftSwipe) ||
54+
(!self.popOnRightToLeft && !rightToLeftSwipe)) {
5355
self.interactionInProgress = YES;
5456
[_viewController.navigationController popViewControllerAnimated:YES];
5557
}

InteractionControllers/CEHorizontalSwipeRightInteractionController.h

Lines changed: 0 additions & 19 deletions
This file was deleted.

InteractionControllers/CEHorizontalSwipeRightInteractionController.m

Lines changed: 0 additions & 118 deletions
This file was deleted.

TransitionsDemo/TransitionsDemo.xcodeproj/project.pbxproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
72EE96D817EF47A60097DF82 /* CECardsAnimationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 72EE96D717EF47A60097DF82 /* CECardsAnimationController.m */; };
3333
72EE96DB17EF66040097DF82 /* CEVerticalSwipeInteractionController.m in Sources */ = {isa = PBXBuildFile; fileRef = 72EE96DA17EF66040097DF82 /* CEVerticalSwipeInteractionController.m */; };
3434
7D0D046C1816DBA700F289A6 /* CENatGeoAnimationController.m in Sources */ = {isa = PBXBuildFile; fileRef = 7D0D046B1816DBA700F289A6 /* CENatGeoAnimationController.m */; };
35-
BC466838198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.m in Sources */ = {isa = PBXBuildFile; fileRef = BC466837198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.m */; };
3635
BC46683B198B2E6700A07DF8 /* CEPanAnimationController.m in Sources */ = {isa = PBXBuildFile; fileRef = BC46683A198B2E6700A07DF8 /* CEPanAnimationController.m */; };
3736
/* End PBXBuildFile section */
3837

@@ -84,8 +83,6 @@
8483
72EE96DA17EF66040097DF82 /* CEVerticalSwipeInteractionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CEVerticalSwipeInteractionController.m; sourceTree = "<group>"; };
8584
7D0D046A1816DBA700F289A6 /* CENatGeoAnimationController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CENatGeoAnimationController.h; sourceTree = "<group>"; };
8685
7D0D046B1816DBA700F289A6 /* CENatGeoAnimationController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CENatGeoAnimationController.m; sourceTree = "<group>"; };
87-
BC466836198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CEHorizontalSwipeRightInteractionController.h; sourceTree = "<group>"; };
88-
BC466837198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CEHorizontalSwipeRightInteractionController.m; sourceTree = "<group>"; };
8986
BC466839198B2E6700A07DF8 /* CEPanAnimationController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CEPanAnimationController.h; sourceTree = "<group>"; };
9087
BC46683A198B2E6700A07DF8 /* CEPanAnimationController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CEPanAnimationController.m; sourceTree = "<group>"; };
9188
/* End PBXFileReference section */
@@ -196,8 +193,6 @@
196193
7273236417DFBF140072C7FD /* InteractionControllers */ = {
197194
isa = PBXGroup;
198195
children = (
199-
BC466836198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.h */,
200-
BC466837198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.m */,
201196
7273236517DFBF140072C7FD /* CEBaseInteractionController.h */,
202197
7273236617DFBF140072C7FD /* CEBaseInteractionController.m */,
203198
7273236717DFBF140072C7FD /* CEHorizontalSwipeInteractionController.h */,
@@ -284,7 +279,6 @@
284279
72C15E1117E10C620056B3F9 /* CECrossfadeAnimationController.m in Sources */,
285280
72EC05A917E7B1BE00DCB9A3 /* CEPinchInteractionController.m in Sources */,
286281
7273233017DFBD4D0072C7FD /* AppDelegate.m in Sources */,
287-
BC466838198B2AC900A07DF8 /* CEHorizontalSwipeRightInteractionController.m in Sources */,
288282
7273232C17DFBD4D0072C7FD /* main.m in Sources */,
289283
7273236017DFBEBF0072C7FD /* CETurnAnimationController.m in Sources */,
290284
7273236A17DFBF140072C7FD /* CEHorizontalSwipeInteractionController.m in Sources */,

TransitionsDemo/TransitionsDemo/SettingsViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ @implementation SettingsViewController {
2424
- (id)initWithCoder:(NSCoder *)aDecoder {
2525
if (self = [super initWithCoder:aDecoder]) {
2626
_animationControllers = @[@"None", @"Portal", @"Cards", @"Fold", @"Explode", @"Flip", @"Turn", @"Crossfade", @"NatGeo", @"Cube",@"Pan"];
27-
_interactionControllers = @[@"None", @"HorizontalSwipe", @"HorizontalSwipeRight",@"VerticalSwipe", @"Pinch"];
27+
_interactionControllers = @[@"None", @"HorizontalSwipe" ,@"VerticalSwipe", @"Pinch"];
2828
}
2929
return self;
3030
}

0 commit comments

Comments
 (0)