カスタムルールのサンプルを追加する

Rules/CallStaticMethodInClassRule.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace Rules;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Rules\Rule;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\RuleErrorBuilder;
+
+/**
+ * @implements Rule<StaticCall>
+ */
+final class CallStaticMethodInClassRule implements Rule
+{
+    public function getNodeType(): string
+    {
+        return StaticCall::class;
+    }
+
+    public function processNode(Node $node, Scope $scope): array
+    {
+        /** @var StaticCall $node */
+        if ($this->shouldSkip($node)) {
+            return [];
+        }
+        if ($scope->isInClass()) {
+            return [
+                RuleErrorBuilder::message(
+                    'Use constructor injection for dependent classes.'
+                )->build(),
+            ];
+        }
+        return [];
+    }
+
+    private function shouldSkip(StaticCall $staticCall): bool
+    {
+        if ($staticCall->class instanceof Expr) {
+            return false;
+        }
+        if ($staticCall->class->isSpecialClassName()) {
+            return true;
+        }
+        return false;
+    }
+}

Tests/CallStaticMethodInClassRuleTest/CallStaticMethodInClassRuleTest.php

@@ -0,0 +1,37 @@
+<?php declare(strict_types = 1);
+
+namespace Tests\CallStaticMethodInClassRuleTest;
+
+use Rules\CallStaticMethodInClassRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<CallStaticMethodInClassRuleTest>
+ */
+class CallStaticMethodInClassRuleTest extends RuleTestCase
+{
+    protected function getRule(): Rule
+    {
+        return new CallStaticMethodInClassRule();
+    }
+
+    public function testRule(): void
+    {
+        $this->analyse([__DIR__ . '/data/call-static-method-in-class-rule.php'], [
+            [
+                'Use constructor injection for dependent classes.',
+                8,
+            ],
+            [
+                'Use constructor injection for dependent classes.',
+                13,
+            ],
+        ]);
+    }
+
+//    public static function getAdditionalConfigFiles(): array
+//    {
+//        return [__DIR__ . '/../extension.neon'];
+//    }
+}

Tests/CallStaticMethodInClassRuleTest/data/call-static-method-in-class-rule.php

@@ -0,0 +1,15 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+class SomeClass extends SomeParentClass
+{
+    public function someMethod(): void {
+        SomeStaticClass::someStaticMethod();
+        self::someStaticMethod();
+        static::someStaticMethod();
+        parent::someStaticMethod();
+        $someStaticClass = 'SomeStaticClass';
+        $someStaticClass::someStaticMethod();
+    }
+}

phpstan.neon

@@ -1,2 +1,3 @@
 rules:
     - Rules\MyRule
+    - Rules\CallStaticMethodInClassRule