Cleaned up leaked global vars and added .jshintrc

Author: Dmitriy Kubyshkin

.jshintrc

@@ -0,0 +1,17 @@
+{
+  "curly": true,
+  "eqeqeq": true,
+  "immed": true,
+  "latedef": true,
+  "newcap": true,
+  "noarg": true,
+  "sub": true,
+  "expr": true,
+  "undef": true,
+  "unused": true,
+  "boss": true,
+  "eqnull": true,
+  "devel": true,
+  "node": true,
+  "browser": true
+}

lib/CanvasTextEditor.js

@@ -9,7 +9,7 @@ var FontMetrics = require('FontMetrics'),
  * @constructor
  */
 var CanvasTextEditor = function(doc, options) {
-  this._document = doc || (new Document);
+  this._document = doc || (new Document());
 
   this.options = {
     textColor: 'WindowText',
@@ -24,7 +24,7 @@ var CanvasTextEditor = function(doc, options) {
   };
 
   if (typeof options === 'object') {
-    for(key in options) {
+    for(var key in options) {
       this.options[key] = options[key];
     }
   }
@@ -133,8 +133,7 @@ CanvasTextEditor.prototype.selectionChange = function() {
 
   // if it's not we put together selected text from document
   if (!this._selection.isEmpty()) {
-    var ranges = this._selection.lineRanges(),
-        line = '';
+    var ranges = this._selection.lineRanges();
     for(var key in ranges) {
       selectedText += this._document.getLine(parseInt(key)).slice(
         ranges[key][0], ranges[key][1] === true ? undefined : ranges[key][1]
@@ -213,7 +212,9 @@ CanvasTextEditor.prototype.render = function() {
       selectionWidth = 0;
 
   // Making sure we don't render something that we won't see
-  if (lineCount < maxHeight) maxHeight = lineCount;
+  if (lineCount < maxHeight) {
+    maxHeight = lineCount;
+  }
 
   // Clearing previous iteration
   this.context.fillStyle = this.options.backgroundColor;
@@ -241,7 +242,7 @@ CanvasTextEditor.prototype.render = function() {
         topOffset,
         selectionWidth,
         lineHeight
-      )
+      );
 
       // Restoring fill color for the text
       this.context.fillStyle = this.options.textColor;

lib/Document.js

@@ -4,8 +4,8 @@
  * @param {string} text Full document text.
  * @constructor
  */
-Document = function(text) {
-  text || (text = '');
+var Document = function(text) {
+  text = text || '';
   this.storage = Document.prepareText(text);
 };
 
@@ -55,9 +55,9 @@ Document.prototype.getLine = function(index) {
  */
 Document.prototype.getLength = function() {
   var sum = 0;
-  for (var i = this.storage.length - 1; i >= 0; --i) {
-    sum += this.storage[i].length
-  };
+  for(var i = this.storage.length - 1; i >= 0; --i) {
+    sum += this.storage[i].length;
+  }
   return sum;
 };
 
@@ -67,8 +67,10 @@ Document.prototype.getLength = function() {
  * @return {string|undefined}
  */
 Document.prototype.charAt = function(column, row) {
-  var row = this.storage[row];
-  if (row) return row.charAt(column);
+  row = this.storage[row];
+  if (row){
+    return row.charAt(column);
+  }
 };
 
 /**
@@ -85,7 +87,9 @@ Document.prototype.insertText = function(text, column, row) {
   // First we calculate new column position because
   // text array will be changed in the process
   var newColumn = text[text.length - 1].length;
-  if (text.length === 1) newColumn += column;
+  if (text.length === 1) {
+    newColumn += column;
+  }
 
   // append remainder of the current line to last line in new text
   text[text.length - 1] += this.storage[row].substr(column);
@@ -176,4 +180,4 @@ Document.prototype.deleteChar = function(forward, startColumn, startRow) {
   }
 
   return this.deleteRange(startColumn, startRow, endColumn, endRow);
-};
+};

lib/Selection.js

@@ -3,7 +3,7 @@
  * @param {Editor} editor.
  * @constructor
  */
-Selection = function(editor, color) {
+var Selection = function(editor, color) {
   this.editor = editor;
   color || (color = '#000');
 
@@ -62,14 +62,16 @@ Selection.prototype.blink = function() {
  * @return {Array}
  */
 Selection.prototype.lineRanges = function() {
-  if (this.isEmpty()) return {};
+  if (this.isEmpty()) {
+    return {};
+  }
   var ranges = {},
       character = this.start.character,
       line = this.start.line;
-  for (; line <= this.end.line ; line++) {
+  for(; line <= this.end.line ; line++) {
     ranges[line] = ([character, line !== this.end.line || this.end.character]);
     character = 0;
-  };
+  }
   return ranges;
 };
 
@@ -186,7 +188,7 @@ Selection.prototype._doSetPosition = function(character, line, keepSelection) {
   // If this is a selection range
   if (keepSelection) {
 
-    compare = this.comparePosition({
+    var compare = this.comparePosition({
       line: line,
       character: character
     }, this.start);
@@ -213,7 +215,7 @@ Selection.prototype._doSetPosition = function(character, line, keepSelection) {
       var temp = {
         line: this.start.line,
         character: this.start.character
-      }
+      };
       this.start.line = this.end.line;
       this.start.character = this.end.character;
       this.end.line = temp.line;
@@ -236,7 +238,7 @@ Selection.prototype.getPosition = function() {
   } else {
     return [this.start.character, this.start.line];
   }
-}
+};
 
 /**
  * Moves up specified amount of lines.

scripts/build.js

@@ -1,7 +1,5 @@
 var common  = require('./common');
 var fs      = require('fs');
-var jsp = require("uglify-js").parser;
-var pro = require("uglify-js").uglify;
 
 common.package.compile(function (err, source){
   var dir = __dirname + '/../build';
@@ -14,12 +12,4 @@ common.package.compile(function (err, source){
   var path = dir + '/' + common.name + '.js';
   fs.writeFileSync(path, source);
   console.log('Developer version: ' + path.replace(__dirname + '/../', ''));
-  
-  // And production one
-  var minPath = dir + '/' + common.name + '.min.js';
-  var ast = jsp.parse(source); // parse code and get the initial AST
-  ast = pro.ast_mangle(ast); // get a new AST with mangled names
-  ast = pro.ast_squeeze(ast); // get an AST with compression optimizations
-  fs.writeFile(minPath, pro.gen_code(ast));
-  console.log('Minified version: ' + minPath.replace(__dirname + '/../', ''));
-})
+});