Make use of exclude_lines regexes for coverage

Author: Cito

.coveragerc

@@ -9,4 +9,8 @@ omit =
 exclude_lines =
     pragma: no cover
     raise NotImplementedError
+    raise TypeError\(f?"Unexpected
+    if TYPE_CHECKING:
+    ^\s+...$
+    ^\s+pass$
 ignore_errors = True

src/graphql/error/format_error.py

@@ -1,6 +1,6 @@
 from typing import Any, Dict, TYPE_CHECKING
 
-if TYPE_CHECKING:  # pragma: no cover
+if TYPE_CHECKING:
     from .graphql_error import GraphQLError  # noqa: F401
 
 

src/graphql/error/graphql_error.py

@@ -3,7 +3,7 @@
 
 from .format_error import format_error
 
-if TYPE_CHECKING:  # pragma: no cover
+if TYPE_CHECKING:
     from ..language.ast import Node  # noqa: F401
     from ..language.location import SourceLocation  # noqa: F401
     from ..language.source import Source  # noqa: F401

src/graphql/error/located_error.py

@@ -2,7 +2,7 @@
 
 from .graphql_error import GraphQLError
 
-if TYPE_CHECKING:  # pragma: no cover
+if TYPE_CHECKING:
     from ..language.ast import Node  # noqa: F401
 
 __all__ = ["located_error"]

src/graphql/language/location.py

@@ -1,6 +1,6 @@
 from typing import NamedTuple, TYPE_CHECKING
 
-if TYPE_CHECKING:  # pragma: no cover
+if TYPE_CHECKING:
     from .source import Source  # noqa: F401
 
 __all__ = ["get_location", "SourceLocation"]

src/graphql/type/definition.py

@@ -56,7 +56,7 @@
 )
 from ..utilities.value_from_ast_untyped import value_from_ast_untyped
 
-if TYPE_CHECKING:  # pragma: no cover
+if TYPE_CHECKING:
     from .schema import GraphQLSchema  # noqa: F401
 
 __all__ = [
@@ -265,12 +265,12 @@ def assert_named_type(type_: Any) -> GraphQLNamedType:
 
 @overload
 def get_named_type(type_: None) -> None:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def get_named_type(type_: GraphQLType) -> GraphQLNamedType:
-    ...  # pragma: no cover
+    ...
 
 
 def get_named_type(type_):
@@ -1539,17 +1539,17 @@ def assert_nullable_type(type_: Any) -> GraphQLNullableType:
 
 @overload
 def get_nullable_type(type_: None) -> None:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def get_nullable_type(type_: GraphQLNullableType) -> GraphQLNullableType:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def get_nullable_type(type_: GraphQLNonNull) -> GraphQLNullableType:
-    ...  # pragma: no cover
+    ...
 
 
 def get_nullable_type(type_):

src/graphql/utilities/ast_from_value.py

@@ -130,4 +130,4 @@ def ast_from_value(value: Any, type_: GraphQLInputType) -> Optional[ValueNode]:
         raise TypeError(f"Cannot convert value to AST: {inspect(serialized)}.")
 
     # Not reachable. All possible input types have been considered.
-    raise TypeError(f"Unexpected input type: {inspect(type_)}.")  # pragma: no cover
+    raise TypeError(f"Unexpected input type: {inspect(type_)}.")

src/graphql/utilities/coerce_input_value.py

@@ -155,4 +155,4 @@ def coerce_input_value(
         return parse_result
 
     # Not reachable. All possible input types have been considered.
-    raise TypeError(f"Unexpected input type: {inspect(type_)}.")  # pragma: no cover
+    raise TypeError(f"Unexpected input type: {inspect(type_)}.")

src/graphql/utilities/find_breaking_changes.py

@@ -540,7 +540,7 @@ def type_kind_name(type_: GraphQLNamedType) -> str:
         return "an Input type"
 
     # Not reachable. All possible output types have been considered.
-    raise TypeError(f"Unexpected type {inspect(type)}")  # pragma: no cover
+    raise TypeError(f"Unexpected type {inspect(type)}")
 
 
 def stringify_value(value: Any, type_: GraphQLInputType) -> str:

src/graphql/utilities/lexicographic_sort_schema.py

@@ -136,7 +136,7 @@ def sort_named_type(type_: GraphQLNamedType) -> GraphQLNamedType:
             return GraphQLInputObjectType(**kwargs)
 
         # Not reachable. All possible types have been considered.
-        raise TypeError(f"Unexpected type: {inspect(type_)}.")  # pragma: no cover
+        raise TypeError(f"Unexpected type: {inspect(type_)}.")
 
     type_map: Dict[str, GraphQLNamedType] = {
         type_.name: sort_named_type(type_)

src/graphql/utilities/schema_printer.py

@@ -142,7 +142,7 @@ def print_type(type_: GraphQLNamedType) -> str:
         return print_input_object(type_)
 
     # Not reachable. All possible types have been considered.
-    raise TypeError(f"Unexpected type: {inspect(type_)}.")  # pragma: no cover
+    raise TypeError(f"Unexpected type: {inspect(type_)}.")
 
 
 def print_scalar(type_: GraphQLScalarType) -> str:

src/graphql/utilities/type_from_ast.py

@@ -17,26 +17,26 @@
 def type_from_ast(
     schema: GraphQLSchema, type_node: NamedTypeNode
 ) -> Optional[GraphQLNamedType]:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def type_from_ast(
     schema: GraphQLSchema, type_node: ListTypeNode
 ) -> Optional[GraphQLList]:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def type_from_ast(
     schema: GraphQLSchema, type_node: NonNullTypeNode
 ) -> Optional[GraphQLNonNull]:
-    ...  # pragma: no cover
+    ...
 
 
 @overload
 def type_from_ast(schema: GraphQLSchema, type_node: TypeNode) -> Optional[GraphQLType]:
-    ...  # pragma: no cover
+    ...
 
 
 def type_from_ast(schema, type_node):

src/graphql/utilities/value_from_ast.py

@@ -137,7 +137,7 @@ def value_from_ast(
         return result
 
     # Not reachable. All possible input types have been considered.
-    raise TypeError(f"Unexpected input type: {inspect(type_)}.")  # pragma: no cover
+    raise TypeError(f"Unexpected input type: {inspect(type_)}.")
 
 
 def is_missing_variable(

src/graphql/validation/rules/possible_type_extensions.py

@@ -92,7 +92,7 @@ def type_to_ext_kind(type_: Any) -> str:
         return "input_object_type_extension"
 
     # Not reachable. All possible types have been considered.
-    raise TypeError(f"Unexpected type: {inspect(type_)}.")  # pragma: no cover
+    raise TypeError(f"Unexpected type: {inspect(type_)}.")
 
 
 _type_names_for_extension_kinds = {

tests/execution/test_union_interface.py

@@ -113,7 +113,7 @@ def resolve_pet_type(value, _info, _type):
         return CatType
 
     # Not reachable. All possible types have been considered.
-    raise TypeError  # pragma: no cover
+    raise TypeError("Unexpected pet type")
 
 
 PetType = GraphQLUnionType("Pet", [DogType, CatType], resolve_type=resolve_pet_type)

tests/pyutils/test_event_emitter.py

@@ -9,11 +9,11 @@ def describe_event_emitter():
     def add_and_remove_listeners():
         emitter = EventEmitter()
 
-        def listener1(value):
-            pass  # pragma: no cover
+        def listener1(_value):
+            pass
 
-        def listener2(value):
-            pass  # pragma: no covers
+        def listener2(_value):
+            pass
 
         emitter.add_listener("foo", listener1)
         emitter.add_listener("foo", listener2)