Improve coverage in tests

Author: Cito

Diff for: .coveragerc

@@ -8,11 +8,11 @@ omit =
 [report]
 exclude_lines =
     pragma: no cover
-    pragma: false coverage
     raise NotImplementedError
     raise TypeError\(f?"Unexpected
+    assert False,
     if MYPY:
     if TYPE_CHECKING:
-    ^\s+...$
+    ^\s+\.\.\.$
     ^\s+pass$
 ignore_errors = True

Diff for: src/graphql/execution/execute.py

@@ -487,7 +487,7 @@ def collect_fields(
                     fields,
                     visited_fragment_names,
                 )
-            elif isinstance(selection, FragmentSpreadNode):  # pragma: no cover
+            elif isinstance(selection, FragmentSpreadNode):  # pragma: no cover else
                 frag_name = selection.name.value
                 if frag_name in visited_fragment_names or not self.should_include_node(
                     selection

Diff for: src/graphql/execution/values.py

@@ -96,7 +96,7 @@ def coerce_variable_values(
                 coerced_values[var_name] = value_from_ast(
                     var_def_node.default_value, var_type
                 )
-            elif is_non_null_type(var_type):  # pragma: false coverage
+            elif is_non_null_type(var_type):  # pragma: no cover else
                 var_type_str = inspect(var_type)
                 on_error(
                     GraphQLError(
@@ -163,13 +163,13 @@ def get_argument_values(
         if argument_node is None:
             if arg_def.default_value is not Undefined:
                 coerced_values[arg_def.out_name or name] = arg_def.default_value
-            elif is_non_null_type(arg_type):
+            elif is_non_null_type(arg_type):  # pragma: no cover else
                 raise GraphQLError(
                     f"Argument '{name}' of required type '{arg_type}'"
                     " was not provided.",
                     node,
                 )
-            continue  # pragma: false coverage
+            continue  # pragma: no cover
 
         value_node = argument_node.value
         is_null = isinstance(argument_node.value, NullValueNode)
@@ -179,14 +179,14 @@ def get_argument_values(
             if variable_values is None or variable_name not in variable_values:
                 if arg_def.default_value is not Undefined:
                     coerced_values[arg_def.out_name or name] = arg_def.default_value
-                elif is_non_null_type(arg_type):
+                elif is_non_null_type(arg_type):  # pragma: no cover else
                     raise GraphQLError(
                         f"Argument '{name}' of required type '{arg_type}'"
                         f" was provided the variable '${variable_name}'"
                         " which was not provided a runtime value.",
                         value_node,
                     )
-                continue  # pragma: false coverage
+                continue  # pragma: no cover
             is_null = variable_values[variable_name] is None
 
         if is_null and is_non_null_type(arg_type):

Diff for: src/graphql/utilities/build_client_schema.py

@@ -122,7 +122,7 @@ def get_interface_type(type_ref: Dict) -> GraphQLInterfaceType:
     def build_type(type_: Dict) -> GraphQLNamedType:
         if type_ and "name" in type_ and "kind" in type_:
             builder = type_builders.get(cast(str, type_["kind"]))
-            if builder:
+            if builder:  # pragma: no cover else
                 return cast(GraphQLNamedType, builder(type_))
         raise TypeError(
             "Invalid or incomplete introspection result."

Diff for: src/graphql/utilities/coerce_input_value.py

@@ -98,7 +98,7 @@ def coerce_input_value(
                 if field.default_value is not Undefined:
                     # Use out name as name if it exists (extension of GraphQL.js).
                     coerced_dict[field.out_name or field_name] = field.default_value
-                elif is_non_null_type(field.type):
+                elif is_non_null_type(field.type):  # pragma: no cover else
                     type_str = inspect(field.type)
                     on_error(
                         path.as_list() if path else [],

Diff for: src/graphql/utilities/introspection_from_schema.py

@@ -29,8 +29,8 @@ def introspection_from_schema(
     result = execute(schema, document)
     if not isinstance(result, ExecutionResult):  # pragma: no cover
         raise RuntimeError("Introspection cannot be executed")
-    if result.errors or not result.data:
-        raise result.errors[0] if result.errors else GraphQLError(
-            "Introspection did not return a result"
-        )
+    if result.errors:  # pragma: no cover
+        raise result.errors[0]
+    if not result.data:  # pragma: no cover
+        raise GraphQLError("Introspection did not return a result")
     return result.data

Diff for: src/graphql/utilities/value_from_ast.py

@@ -110,7 +110,7 @@ def value_from_ast(
                 if field.default_value is not Undefined:
                     # Use out name as name if it exists (extension of GraphQL.js).
                     coerced_obj[field.out_name or field_name] = field.default_value
-                elif is_non_null_type(field.type):  # pragma: false coverage
+                elif is_non_null_type(field.type):  # pragma: no cover else
                     return Undefined
                 continue
             field_value = value_from_ast(field_node.value, field.type, variables)

Diff for: src/graphql/validation/rules/known_directives.py

@@ -91,17 +91,18 @@ def enter_directive(self, node: DirectiveNode, _key, _parent, _path, ancestors):
 
 def get_directive_location_for_ast_path(ancestors):
     applied_to = ancestors[-1]
-    if isinstance(applied_to, Node):
-        kind = applied_to.kind
-        if kind == "operation_definition":
-            applied_to = cast(OperationDefinitionNode, applied_to)
-            return _operation_location[applied_to.operation.value]
-        elif kind == "input_value_definition":
-            parent_node = ancestors[-3]
-            return (
-                DirectiveLocation.INPUT_FIELD_DEFINITION
-                if parent_node.kind == "input_object_type_definition"
-                else DirectiveLocation.ARGUMENT_DEFINITION
-            )
-        else:
-            return _directive_location.get(kind)
+    if not isinstance(applied_to, Node):  # pragma: no cover
+        raise TypeError("Unexpected error in directive.")
+    kind = applied_to.kind
+    if kind == "operation_definition":
+        applied_to = cast(OperationDefinitionNode, applied_to)
+        return _operation_location[applied_to.operation.value]
+    elif kind == "input_value_definition":
+        parent_node = ancestors[-3]
+        return (
+            DirectiveLocation.INPUT_FIELD_DEFINITION
+            if parent_node.kind == "input_object_type_definition"
+            else DirectiveLocation.ARGUMENT_DEFINITION
+        )
+    else:
+        return _directive_location.get(kind)

Diff for: src/graphql/validation/rules/overlapping_fields_can_be_merged.py

@@ -690,7 +690,7 @@ def collect_fields_and_fragment_names(
             )
         elif isinstance(selection, FragmentSpreadNode):
             fragment_names[selection.name.value] = True
-        elif isinstance(selection, InlineFragmentNode):
+        elif isinstance(selection, InlineFragmentNode):  # pragma: no cover else
             type_condition = selection.type_condition
             inline_fragment_type = (
                 type_from_ast(context.schema, type_condition)

Diff for: tests/pyutils/test_inspect.py

@@ -100,10 +100,10 @@ def overly_large_int():
             assert inspect(n) == r
 
     def inspect_function():
-        assert inspect(lambda: 0) == "<function>"
+        assert inspect(lambda: 0) == "<function>"  # pragma: no cover
 
         def test_func():
-            return None
+            pass
 
         assert inspect(test_func) == "<function test_func>"
 
@@ -114,7 +114,7 @@ def inspect_exception():
     def inspect_class_and_method():
         class TestClass:
             def test_method(self):
-                return None
+                pass
 
         assert inspect(TestClass) == "<class TestClass>"
         assert inspect(TestClass()) == "<TestClass instance>"
@@ -132,15 +132,15 @@ class TestClass(metaclass=MetaClass):
 
     def inspect_generator():
         def test_generator():
-            yield None
+            yield None  # pragma: no cover
 
         assert inspect(test_generator) == "<generator function test_generator>"
         assert inspect(test_generator()) == "<generator test_generator>"
 
     @mark.asyncio
     async def inspect_coroutine():
         async def test_coroutine():
-            return None
+            pass
 
         assert inspect(test_coroutine) == "<coroutine function test_coroutine>"
         coroutine_object = test_coroutine()
@@ -149,7 +149,7 @@ async def test_coroutine():
 
     def inspect_async_generator():
         async def test_async_generator():
-            yield None
+            yield None  # pragma: no cover
 
         assert inspect(test_async_generator) == (
             "<async generator function test_async_generator>"

Diff for: tests/pyutils/test_is_nullish.py

@@ -3,22 +3,6 @@
 from graphql.pyutils import is_nullish, Undefined
 
 
-class FakeNumpyArray:
-    def __eq__(self, other):
-        # Numpy arrays return an array when compared with another numpy array
-        # containing the pointwise equality of the two
-        if isinstance(other, FakeNumpyArray):
-            return FakeNumpyArray()
-        else:
-            return False
-
-    def __bool__(self):
-        raise TypeError(
-            "The truth value of an array with more than one element is "
-            "ambiguous. Use a.any() or a.all()"
-        )
-
-
 def describe_is_nullish():
     def null_is_nullish():
         assert is_nullish(None) is True

Diff for: tests/subscription/test_map_async_iterator.py

@@ -310,15 +310,18 @@ async def __anext__(self):
                     raise StopAsyncIteration
                 return self.counter
 
+        def double(x):
+            return x + x
+
         for iterator in source, Source:
-            doubles = MapAsyncIterator(iterator(), lambda x: x + x)
+            doubles = MapAsyncIterator(iterator(), double)
 
             await doubles.aclose()
 
             with raises(StopAsyncIteration):
                 await anext(doubles)
 
-            doubles = MapAsyncIterator(iterator(), lambda x: x + x)
+            doubles = MapAsyncIterator(iterator(), double)
 
             assert await anext(doubles) == 2
             assert await anext(doubles) == 4
@@ -327,7 +330,7 @@ async def __anext__(self):
             with raises(StopAsyncIteration):
                 await anext(doubles)
 
-            doubles = MapAsyncIterator(iterator(), lambda x: x + x)
+            doubles = MapAsyncIterator(iterator(), double)
 
             assert await anext(doubles) == 2
             assert await anext(doubles) == 4
@@ -350,7 +353,7 @@ async def __anext__(self):
 
             await doubles.aclose()
 
-            doubles = MapAsyncIterator(iterator(), lambda x: x + x)
+            doubles = MapAsyncIterator(iterator(), double)
 
             assert await anext(doubles) == 2
             assert await anext(doubles) == 4

Diff for: tests/subscription/test_subscribe.py

@@ -139,7 +139,7 @@ async def accepts_positional_arguments():
 
         async def empty_async_iterator(_info):
             for value in ():  # type: ignore
-                yield value
+                yield value  # pragma: no cover
 
         ai = await subscribe(
             email_schema, document, {"importantEmail": empty_async_iterator}
@@ -255,7 +255,7 @@ def subscribe_important(_inbox, _info):
             did_resolve["importantEmail"] = True
             return EventEmitterAsyncIterator(EventEmitter(), "event")
 
-        def subscribe_non_important(_inbox, _info):
+        def subscribe_non_important(_inbox, _info):  # pragma: no cover
             did_resolve["nonImportantEmail"] = True
             return EventEmitterAsyncIterator(EventEmitter(), "event")
 

Diff for: tests/test_docs.py

@@ -10,7 +10,7 @@
 
 def get_snippets(source, indent=4):
     """Get all code snippets from a given documentation source file."""
-    if not source.endswith(".rst"):
+    if not source.endswith(".rst"):  # pragma: no cover
         source += ".rst"
     source_path = Path(__file__).parents[1] / "docs" / source
     lines = open(source_path).readlines()

Diff for: tests/test_version.py

@@ -74,7 +74,7 @@ def version_info_has_correct_fields():
             assert version_info.major == int(groups[0])
             assert version_info.minor == int(groups[1])
             assert version_info.micro == int(groups[2])
-            if groups[3] is None:
+            if groups[3] is None:  # pragma: no cover
                 assert groups[4] is None
             else:
                 assert version_info.releaselevel[:1] == groups[3]
@@ -100,7 +100,7 @@ def version_info_js_has_correct_fields():
             assert version_info_js.major == int(groups[0])
             assert version_info_js.minor == int(groups[1])
             assert version_info_js.micro == int(groups[2])
-            if groups[3] is None:
+            if groups[3] is None:  # pragma: no cover
                 assert groups[4] is None
             else:
                 assert version_info_js.releaselevel[:1] == groups[3]