Skip to content

Commit e33b8d9

Browse files
authored
Correct the type of return value of FinalizationRegistry.unregister (microsoft#57948)
1 parent 05f4dba commit e33b8d9

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

src/lib/es2021.weakref.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ interface FinalizationRegistry<T> {
4242
* @param unregisterToken The token that was used as the unregisterToken argument when calling
4343
* register to register the target value.
4444
*/
45-
unregister(unregisterToken: WeakKey): void;
45+
unregister(unregisterToken: WeakKey): boolean;
4646
}
4747

4848
interface FinalizationRegistryConstructor {

tests/baselines/reference/acceptSymbolAsWeakType.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,14 +168,14 @@ f.register(s, null);
168168
> : ^^^^^^
169169

170170
f.unregister(s);
171-
>f.unregister(s) : void
172-
> : ^^^^
173-
>f.unregister : (unregisterToken: WeakKey) => void
174-
> : ^ ^^ ^^^^^^^^^
171+
>f.unregister(s) : boolean
172+
> : ^^^^^^^
173+
>f.unregister : (unregisterToken: WeakKey) => boolean
174+
> : ^ ^^ ^^^^^^^^^^^^
175175
>f : FinalizationRegistry<unknown>
176176
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
177-
>unregister : (unregisterToken: WeakKey) => void
178-
> : ^ ^^ ^^^^^^^^^
177+
>unregister : (unregisterToken: WeakKey) => boolean
178+
> : ^ ^^ ^^^^^^^^^^^^
179179
>s : symbol
180180
> : ^^^^^^
181181

tests/baselines/reference/dissallowSymbolAsWeakType.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -168,14 +168,14 @@ f.register(s, null);
168168
> : ^^^^^^
169169

170170
f.unregister(s);
171-
>f.unregister(s) : void
172-
> : ^^^^
173-
>f.unregister : (unregisterToken: WeakKey) => void
174-
> : ^ ^^ ^^^^^^^^^
171+
>f.unregister(s) : boolean
172+
> : ^^^^^^^
173+
>f.unregister : (unregisterToken: WeakKey) => boolean
174+
> : ^ ^^ ^^^^^^^^^^^^
175175
>f : FinalizationRegistry<unknown>
176176
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
177-
>unregister : (unregisterToken: WeakKey) => void
178-
> : ^ ^^ ^^^^^^^^^
177+
>unregister : (unregisterToken: WeakKey) => boolean
178+
> : ^ ^^ ^^^^^^^^^^^^
179179
>s : symbol
180180
> : ^^^^^^
181181

tests/baselines/reference/esNextWeakRefs_IterableWeakMap.types

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -357,16 +357,16 @@ export class IterableWeakMap<K extends object, V> implements WeakMap<K, V> {
357357
> : ^^^^^^^^^^
358358

359359
this.#finalizationGroup.unregister(ref);
360-
>this.#finalizationGroup.unregister(ref) : void
361-
> : ^^^^
362-
>this.#finalizationGroup.unregister : (unregisterToken: WeakKey) => void
363-
> : ^ ^^ ^^^^^^^^^
360+
>this.#finalizationGroup.unregister(ref) : boolean
361+
> : ^^^^^^^
362+
>this.#finalizationGroup.unregister : (unregisterToken: WeakKey) => boolean
363+
> : ^ ^^ ^^^^^^^^^^^^
364364
>this.#finalizationGroup : FinalizationRegistry<{ readonly ref: WeakRef<object>; readonly set: Set<WeakRef<object>>; }>
365365
> : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
366366
>this : this
367367
> : ^^^^
368-
>unregister : (unregisterToken: WeakKey) => void
369-
> : ^ ^^ ^^^^^^^^^
368+
>unregister : (unregisterToken: WeakKey) => boolean
369+
> : ^ ^^ ^^^^^^^^^^^^
370370
>ref : WeakRef<K>
371371
> : ^^^^^^^^^^
372372

0 commit comments

Comments
 (0)