Skip to content

fix: respect absolute paths for loading local tools #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: respect absolute paths for loading local tools #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/loader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ func openFile(path string) (io.ReadCloser, bool, error) {

func loadLocal(base *source, name string) (*source, bool, error) {
// We want to keep all strings in / format, and only convert to platform specific when reading
filePath := path.Join(base.Path, name)
// This is why we use path instead of filepath.
filePath := name
if !path.IsAbs(name) {
filePath = path.Join(base.Path, name)
}

if s, err := fs.Stat(internal.FS, filepath.Clean(filePath)); err == nil && s.IsDir() {
for _, def := range types.DefaultFiles {
Expand Down