Merge pull request #817 from StrongMonkey/fix-env-duplicate

StrongMonkey · web-flow · commit 3f2a8ee79d02 · 2024-08-23T08:56:25.000-07:00
Fix: Do not return full env map after downloading releases
diff --git a/pkg/repos/runtimes/golang/golang.go b/pkg/repos/runtimes/golang/golang.go
@@ -244,7 +244,7 @@ func getChecksum(ctx context.Context, rel *release, artifactName string) string
 	return ""
 }
 
-func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource string, env []string) (bool, []string, error) {
+func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource string, _ []string) (bool, []string, error) {
 	if !tool.Source.IsGit() {
 		return false, nil, nil
 	}
@@ -264,7 +264,7 @@ func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource str
 		return false, nil, nil
 	}
 
-	return true, env, nil
+	return true, nil, nil
 }
 
 func (r *Runtime) Setup(ctx context.Context, _ types.Tool, dataRoot, toolSource string, env []string) ([]string, error) {

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ func getChecksum(ctx context.Context, rel *release, artifactName string) string`
`244`	`244`	`return ""`
`245`	`245`	`}`
`246`	`246`
`247`		`-func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource string, env []string) (bool, []string, error) {`
	`247`	`+func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource string, _ []string) (bool, []string, error) {`
`248`	`248`	`if !tool.Source.IsGit() {`
`249`	`249`	`return false, nil, nil`
`250`	`250`	`}`
`@@ -264,7 +264,7 @@ func (r *Runtime) Binary(ctx context.Context, tool types.Tool, _, toolSource str`
`264`	`264`	`return false, nil, nil`
`265`	`265`	`}`
`266`	`266`
`267`		`- return true, env, nil`
	`267`	`+ return true, nil, nil`
`268`	`268`	`}`
`269`	`269`
`270`	`270`	`func (r *Runtime) Setup(ctx context.Context, _ types.Tool, dataRoot, toolSource string, env []string) ([]string, error) {`