Skip to content

Commit 6d17084

Browse files
chore: template updates (#139)
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2394acea-a7de-4b59-9a6f-2f3b35d007b5/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)
1 parent d118238 commit 6d17084

File tree

4 files changed

+5
-36
lines changed

4 files changed

+5
-36
lines changed

.pre-commit-config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ repos:
2626
hooks:
2727
- id: black
2828
- repo: https://gitlab.com/pycqa/flake8
29-
rev: 3.9.0
29+
rev: 3.9.1
3030
hooks:
3131
- id: flake8

CONTRIBUTING.rst

+1-15
Original file line numberDiff line numberDiff line change
@@ -160,21 +160,7 @@ Running System Tests
160160
auth settings and change some configuration in your project to
161161
run all the tests.
162162

163-
- System tests will be run against an actual project and
164-
so you'll need to provide some environment variables to facilitate
165-
authentication to your project:
166-
167-
- ``GOOGLE_APPLICATION_CREDENTIALS``: The path to a JSON key file;
168-
Such a file can be downloaded directly from the developer's console by clicking
169-
"Generate new JSON key". See private key
170-
`docs <https://cloud.google.com/storage/docs/authentication#generating-a-private-key>`__
171-
for more details.
172-
173-
- Once you have downloaded your json keys, set the environment variable
174-
``GOOGLE_APPLICATION_CREDENTIALS`` to the absolute path of the json file::
175-
176-
$ export GOOGLE_APPLICATION_CREDENTIALS="/Users/<your_username>/path/to/app_credentials.json"
177-
163+
- System tests will be run against an actual project. You should use local credentials from gcloud when possible. See `Best practices for application authentication <https://cloud.google.com/docs/authentication/best-practices-applications#local_development_and_testing_with_the>`__. Some tests require a service account. For those tests see `Authenticating as a service account <https://cloud.google.com/docs/authentication/production>`__.
178164

179165
*************
180166
Test Coverage

noxfile.py

+2-12
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,9 @@ def lint(session):
6666
session.run("flake8", "pybigquery", "tests")
6767

6868

69-
@nox.session(python="3.6")
69+
@nox.session(python=DEFAULT_PYTHON_VERSION)
7070
def blacken(session):
71-
"""Run black.
72-
73-
Format code to uniform standard.
74-
75-
This currently uses Python 3.6 due to the automated Kokoro run of synthtool.
76-
That run uses an image that doesn't have 3.6 installed. Before updating this
77-
check the state of the `gcp_ubuntu_config` we use for that Kokoro run.
78-
"""
71+
"""Run black. Format code to uniform standard."""
7972
session.install(BLACK_VERSION)
8073
session.run(
8174
"black", *BLACK_PATHS,
@@ -133,9 +126,6 @@ def system(session):
133126
# Check the value of `RUN_SYSTEM_TESTS` env var. It defaults to true.
134127
if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false":
135128
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")
136-
# Sanity check: Only run tests if the environment variable is set.
137-
if not os.environ.get("GOOGLE_APPLICATION_CREDENTIALS", ""):
138-
session.skip("Credentials must be set via environment variable")
139129
# Install pyopenssl for mTLS testing.
140130
if os.environ.get("GOOGLE_API_USE_CLIENT_CERTIFICATE", "false") == "true":
141131
session.install("pyopenssl")

synth.metadata

+1-8
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/python-bigquery-sqlalchemy.git",
7-
"sha": "917919371f8b6af4c90efb084da47d4812206e70"
8-
}
9-
},
10-
{
11-
"git": {
12-
"name": "synthtool",
13-
"remote": "https://github.com/googleapis/synthtool.git",
14-
"sha": "043cc620d6a6111816d9e09f2a97208565fde958"
7+
"sha": "0a3151ba2cb5564ebc1bf2c920b4cab210cd73b8"
158
}
169
}
1710
],

0 commit comments

Comments
 (0)