Skip to content

Commit ade505c

Browse files
authored
Revert "ci: Disable presubmit LLM tests temporarily (#144)" (#148)
This reverts commit 1641aff, which was merged due to automerge label while still being discussed. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
1 parent c3b24b5 commit ade505c

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

tests/system/small/ml/test_llm.py

-24
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ def test_create_text_generator_model(palm2_text_generator_model):
2626
assert palm2_text_generator_model._bqml_model is not None
2727

2828

29-
@pytest.mark.skip(
30-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
31-
)
3229
@pytest.mark.flaky(retries=2, delay=120)
3330
def test_create_text_generator_model_default_session(bq_connection, llm_text_pandas_df):
3431
import bigframes.pandas as bpd
@@ -51,9 +48,6 @@ def test_create_text_generator_model_default_session(bq_connection, llm_text_pan
5148
assert all(series.str.len() > 20)
5249

5350

54-
@pytest.mark.skip(
55-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
56-
)
5751
@pytest.mark.flaky(retries=2, delay=120)
5852
def test_create_text_generator_model_default_connection(llm_text_pandas_df):
5953
from bigframes import _config
@@ -80,9 +74,6 @@ def test_create_text_generator_model_default_connection(llm_text_pandas_df):
8074

8175

8276
# Marked as flaky only because BQML LLM is in preview, the service only has limited capacity, not stable enough.
83-
@pytest.mark.skip(
84-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
85-
)
8677
@pytest.mark.flaky(retries=2, delay=120)
8778
def test_text_generator_predict_default_params_success(
8879
palm2_text_generator_model, llm_text_df
@@ -94,9 +85,6 @@ def test_text_generator_predict_default_params_success(
9485
assert all(series.str.len() > 20)
9586

9687

97-
@pytest.mark.skip(
98-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
99-
)
10088
@pytest.mark.flaky(retries=2, delay=120)
10189
def test_text_generator_predict_series_default_params_success(
10290
palm2_text_generator_model, llm_text_df
@@ -108,9 +96,6 @@ def test_text_generator_predict_series_default_params_success(
10896
assert all(series.str.len() > 20)
10997

11098

111-
@pytest.mark.skip(
112-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
113-
)
11499
@pytest.mark.flaky(retries=2, delay=120)
115100
def test_text_generator_predict_arbitrary_col_label_success(
116101
palm2_text_generator_model, llm_text_df
@@ -123,9 +108,6 @@ def test_text_generator_predict_arbitrary_col_label_success(
123108
assert all(series.str.len() > 20)
124109

125110

126-
@pytest.mark.skip(
127-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
128-
)
129111
@pytest.mark.flaky(retries=2, delay=120)
130112
def test_text_generator_predict_with_params_success(
131113
palm2_text_generator_model, llm_text_df
@@ -157,9 +139,6 @@ def test_create_text_embedding_generator_model_defaults(bq_connection):
157139
assert model._bqml_model is not None
158140

159141

160-
@pytest.mark.skip(
161-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
162-
)
163142
@pytest.mark.flaky(retries=2, delay=120)
164143
def test_embedding_generator_predict_success(
165144
palm2_embedding_generator_model, llm_text_df
@@ -173,9 +152,6 @@ def test_embedding_generator_predict_success(
173152
assert value.size == 768
174153

175154

176-
@pytest.mark.skip(
177-
reason="Temporarily disable to validate the hypothesis that LLM capacity is causing the presubmit tests to take long to run."
178-
)
179155
@pytest.mark.flaky(retries=2, delay=120)
180156
def test_embedding_generator_predict_series_success(
181157
palm2_embedding_generator_model, llm_text_df

0 commit comments

Comments
 (0)