Skip to content

Commit 62a9dc2

Browse files
author
Marc Rasi
committed
Revert "disable completions by default because they are crashy (#87)"
This reverts commit ee0aeeb.
1 parent 6ea957a commit 62a9dc2

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

swift_kernel.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,7 @@ def _init_swift(self):
214214
# SBTarget.CompleteCode API.
215215
# The user can disable/enable using "%disableCompletion" and
216216
# "%enableCompletion".
217-
# TODO: Reenable completions when they become less crashy.
218-
#self.completion_enabled = hasattr(self.target, 'CompleteCode')
219-
self.completion_enabled = False
217+
self.completion_enabled = hasattr(self.target, 'CompleteCode')
220218

221219
def _init_repl_process(self):
222220
self.debugger = lldb.SBDebugger.Create()

test/tests/kernel_tests.py

-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ def test_async_stdout(self):
203203
if msg['msg_type'] == 'status':
204204
break
205205

206-
@unittest.skip # TODO: Reenable.
207206
def test_swift_completion(self):
208207
reply, output_msgs = self.execute_helper(code="""
209208
func aFunctionToComplete() {}

0 commit comments

Comments
 (0)