Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.7.0
Choose a base ref
...
head repository: golang/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.8.0
Choose a head ref
  • 9 commits
  • 14 files changed
  • 6 contributors

Commits on Apr 10, 2023

  1. windows: add JobObjectInformationClass consts for QueryInformationJob…

    …Object
    
    Reference:
    https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-queryinformationjobobject#parameters
    
    Change-Id: I0d10895ffc18b345f371cc7e0cbf8362fd67f71a
    GitHub-Last-Rev: 2816391
    GitHub-Pull-Request: #154
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/481455
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    Reviewed-by: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    masshash authored and alexbrainman committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    f25ff60 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. windows: add Service.ListDependentServices

    This method allows a user to list all Windows services which are
    dependent upon a given service.
    
    This commit makes use of the EnumDependentServices Windows API call.
    Without this, a user would have to iterate through each service on the
    system, and check if the given service is listed in each service's
    dependencies list.
    
    The implementation of ListDependentServices is mostly the same as
    Mgr.ListServices, as the API calls behave in the same way.
    
    Fixes golang/go#56766
    
    Change-Id: I9ec18c97afd02f48deef691ccdd5c26d6501add1
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/451363
    Reviewed-by: Than McIntosh <thanm@google.com>
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Benny Siegert <bsiegert@gmail.com>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    sebsoto authored and alexbrainman committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    dbd8f99 View commit details
    Browse the repository at this point in the history
  2. unix: allow overriding GOOS using GOOS_TARGET in mkpost.go

    mkpost.go is platform independent and can in principle be run on a GOOS
    other than the one we're generating the syscall wrappers for. Allow
    overriding GOOS by setting GOOS_TARGET, similar to other generator
    programs in the repo. This e.g. allows testing mkpost.go changes on a
    different GOOS.
    
    Follows CL 256278 which did the same for mksyscall.go
    
    Change-Id: Ib99aa5cd266f7d27543cf9433cfb028f367eef63
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/484636
    Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
    Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    tklauser authored and gopherbot committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    3125361 View commit details
    Browse the repository at this point in the history
  3. unix: convert Iovec.Base to *byte in mkpost.go on solaris

    Instead of defining a dedicated type goIovec with the correct *byte type
    for its Base field like CL 412496 did, modify the Base field of the
    original type Iovec (generated from struct iovec) in mkpost.go. This is
    akin to how we already change []int8 to []byte for several other types.
    
    Fixes golang/go#55997
    
    Change-Id: If30799bb2bfe6d17678370b45348ff0b7c5de2e9
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/484635
    Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
    Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
    Reviewed-by: David Chase <drchase@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    tklauser authored and gopherbot committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1fb6828 View commit details
    Browse the repository at this point in the history
  4. unix: add UDP socket option constants on linux

    Change-Id: I4c947319f98754a5135b306d8ff042a986ab5440
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/484637
    Reviewed-by: David Chase <drchase@google.com>
    Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
    tklauser authored and gopherbot committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    39c2d6a View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. execabs: let hasExec return false on wasip1

    Wasm cannot execute processes. Follow CL 479622 and update hasExec to
    match internal/testenv.HasExec.
    
    Updates golang/go#58141
    
    Change-Id: Ie44dc356ee589784c44906694fda387fb1448ad5
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/485655
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    tklauser authored and gopherbot committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2a33a30 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. windows/svc/mgr: Service.Control: populate Status when returning cert…

    …ain errors
    
    Fixes golang/go#59015
    
    Change-Id: I45f22049f3a05f807f78d20c9ed67c6c79e3d3c1
    GitHub-Last-Rev: 929aeb4
    GitHub-Pull-Request: #156
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/484895
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    craig65535 authored and alexbrainman committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9524d49 View commit details
    Browse the repository at this point in the history
  2. windows: return error if DecomposeCommandLine parameter contains NUL

    DecomposeCommandLine is documented to use CommandLineToArgv, and the
    CommandLineToArgvW system call inherently does not support strings with
    internal NUL bytes. This CL changes DecomposeCommandLine to reject those
    strings with an error instead of panicking.
    
    Fixes golang/go#58817
    
    Change-Id: I22a026bf2e69344a21f04849c50ba19b6e7b2007
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/487695
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    alexbrainman committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6c52899 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. windows: use unsafe.Add instead of pointer arithmetic on a uintptr

    The existing uintptr arithmetic is arguably valid because the
    environment block is not located within the Go heap
    (see golang/go#58625).
    
    However, unsafe.Add (added in Go 1.17) expresses the same logic with
    fewer conversions, and in addition avoids triggering the unsafeptr
    vet check.
    
    For golang/go#41205.
    
    Change-Id: Ifc509279a13fd707be570908ec779d8518b4f75b
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/492415
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Run-TryBot: Bryan Mills <bcmills@google.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Bryan C. Mills authored and gopherbot committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ca59eda View commit details
    Browse the repository at this point in the history
Loading