Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.23.0
Choose a base ref
...
head repository: golang/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.24.0
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Aug 5, 2024

  1. windows: delete TestGetKeyboardLayout

    According to
    https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getforegroundwindow
    GetForegroundWindow can return nil in some circumstances. So
    GetForegroundWindow cannot be used in the TestGetKeyboardLayout.
    Just delete the test for now.
    
    Fixes golang/go#68671
    
    Change-Id: I7e05ac2f19b1a6310a3f7f690c6d02b0d1f5571e
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/602335
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Ayman Bagabas <ayman.bagabas@gmail.com>
    alexbrainman authored and cherrymui committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    29298aa View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. windows: add enums for IpAdapterUnicastAddress

    These are for the enum fields in IpAdapterUnicastAddress.
    
    Change-Id: Ibcb6ce674ab41a94dbe46d394f035208a94b6dae
    GitHub-Last-Rev: 1837ff9
    GitHub-Pull-Request: #204
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/598895
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    Reviewed-by: David Chase <drchase@google.com>
    database64128 authored and alexbrainman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4c7077e View commit details
    Browse the repository at this point in the history
  2. unix: add missing ETHTOOL_FLAG_ constants

    Some constants were removed in CL 600516 that included changes for the
    Linux kernel 6.10.
    
    This kernel version moved C defines to an enum ethtool_header_flags that
    was not picked up by the mkall.sh script.
    
    For enums, there is a perl script that needs to be run manually, and the
    output must be added by hand to the list of constants in unix/linux/types.go.
    
    See https://elixir.bootlin.com/linux/v6.10.3/source/include/uapi/linux/ethtool_netlink.h#L120
    
    Fixes golang/go#68761
    
    Change-Id: Idb189886d257d0fe66a4e832757a469e17f86c34
    GitHub-Last-Rev: 08b8ef5
    GitHub-Pull-Request: #212
    Reviewed-on: https://go-review.googlesource.com/c/sys/+/604098
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    mauri870 authored and gopherbot committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    914deed View commit details
    Browse the repository at this point in the history
Loading