Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.14.0
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.0
Choose a head ref
  • 5 commits
  • 4 files changed
  • 5 contributors

Commits on May 14, 2025

  1. sync/errgroup: PanicError.Error print stack trace

    Because it is useful to print the stack
    when a nil pointer dereference occurs.
    
    Fixes golang/go#73710
    
    Change-Id: I106ea0bdd70c2a293f5ea889edef9b5ba9db2fbd
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/672635
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Damien Neil <dneil@google.com>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    TryBot-Bypass: Damien Neil <dneil@google.com>
    qiulaidongfeng authored and gopherbot committed May 14, 2025
    Configuration menu
    Copy the full SHA
    d1ac909 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2025

  1. all: replace deprecated ioutil

    Change-Id: I1beb9f5e759127a48c4e5ea0613a5a466886b7c5
    GitHub-Last-Rev: 58038b6
    GitHub-Pull-Request: #28
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/674815
    Reviewed-by: Alan Donovan <adonovan@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    12ya authored and gopherbot committed May 24, 2025
    Configuration menu
    Copy the full SHA
    1869c69 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. errgroup: remove duplicated comment

    Change-Id: I5cdcc5034ccd87b939a406693e97485553ab60fa
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/676715
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Alan Donovan <adonovan@google.com>
    Auto-Submit: Alan Donovan <adonovan@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    xieyuschen authored and gopherbot committed May 28, 2025
    Configuration menu
    Copy the full SHA
    8a14946 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2025

  1. errgroup: revert propagation of panics

    This change reverts CL 644575, which caused panics in the f()
    call after group.Go(f) to be propagated to the subsequent
    group.Wait call. This caused more problems than it solved.
    
    Also:
    - preserve some of the doc comment wording of Group.Go.
    - leave a "tsunami stone" comment in Group.Go.
    
    Fixes golang/go#53757
    Updates golang/go#74275
    Updates golang/go#74304
    Updates golang/go#74306
    
    Change-Id: I6e3992510944db7d69c72eaf241aedf8b84e62dd
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/682935
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: qiu laidongfeng2 <2645477756@qq.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Sean Liao <sean@liao.dev>
    adonovan authored and gopherbot committed Jun 20, 2025
    Configuration menu
    Copy the full SHA
    7fad2c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2025

  1. all: upgrade go directive to at least 1.24.0 [generated]

    By now Go 1.25.0 has been released, and Go 1.23 is no longer supported
    per the Go Release Policy (see https://go.dev/doc/devel/release#policy).
    
    For golang/go#69095.
    
    [git-generate]
    (cd . && go get go@1.24.0 && go mod tidy && go fix ./... && go mod edit -toolchain=none)
    
    Change-Id: Ifa2b9ecc1efe475dfe4d60f41fb3ad2c63896d12
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/695358
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    gopherbot committed Aug 13, 2025
    Configuration menu
    Copy the full SHA
    04914c2 View commit details
    Browse the repository at this point in the history
Loading