Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/oauth2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.29.0
Choose a base ref
...
head repository: golang/oauth2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.30.0
Choose a head ref
  • 9 commits
  • 38 files changed
  • 5 contributors

Commits on Apr 17, 2025

  1. all: make use of oauth.Token.ExpiresIn

    With https://go.dev/issue/61417 implemented, we can use the token type
    directly to unmarshal the JSON fields for the wire format.
    
    While here, remove all uses of the deprecated ioutil package
    as suggested by gopls while making these changes.
    
    Change-Id: I79d82374643007a21b5b3d9a8117bed81273eca5
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/614415
    Reviewed-by: Sean Liao <sean@liao.dev>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    mvdan authored and seankhliao committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    1c06e87 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2025

  1. endpoints: add various endpoints from stale CLs

    Change-Id: Id66b6e0caa86256064f7301b9d25bf861c72d116
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/665235
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Dominik Honnef <dominik@honnef.co>
    Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
    seankhliao committed Apr 21, 2025
    Configuration menu
    Copy the full SHA
    883dc3c View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2025

  1. oauth2: context instead of golang.org/x/net/context in doc

    Change-Id: I377136feb07354904b2f27600f3aef0629ca76f2
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/632295
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    alexandear authored and gopherbot committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    d2c4e0a View commit details
    Browse the repository at this point in the history
  2. oauth2: sync Token.ExpiresIn from internal Token

    The internal.Token type is intended to mirror the public Token type.
    Unmarshalling is sometimes done on the internal token.
    Sync the field addition, and update the conversion.
    
    Updates #61417
    Fixes #746
    
    Change-Id: I55818810394adf743afb8d6d3be477a425c233b5
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/666815
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    seankhliao committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    6968da2 View commit details
    Browse the repository at this point in the history
  3. oauth2: drop dependency on go-cmp

    For #615
    
    Change-Id: I1e17703f5a52240cbd7802ab1da1fd8b24be8d6c
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/666816
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    seankhliao committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    471209b View commit details
    Browse the repository at this point in the history
  4. all: modernize with doc links and any

    Change-Id: If3fc4542b92da802a31dcabc3405f7b1ab06a18d
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/666396
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
    seankhliao authored and gopherbot committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    696f7b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2025

  1. oauth2: replace a magic number with AuthStyleUnknown

    Change-Id: I7e08428b87f141fa6d2932b7d60b3e726a454986
    GitHub-Last-Rev: 0aef667
    GitHub-Pull-Request: #646
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/496075
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    masonelmore authored and gopherbot committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    2d34e30 View commit details
    Browse the repository at this point in the history
  2. internal: include clientID in auth style cache key

    Fixes #654
    
    Change-Id: I735891f2a77c3797662b2eadab7e7828ff14bf5f
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/666915
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Matt Hickford <matt.hickford@gmail.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    seankhliao committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    32d34ef View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2025

  1. oauth2: fix expiration time window check

    Before CL 68017, the test verified that tokens expire exactly one day
    after they are issued, within the time that Exchange() takes to execute.
    A refactoring in the CL extended this time window to a whole day, making
    the check much more lenient.
    
    See: https://go-review.googlesource.com/c/oauth2/+/168017
    Change-Id: I479db429f64b25a711624817c13f068b4675163e
    Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/630495
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    Reviewed-by: Sean Liao <sean@liao.dev>
    Auto-Submit: Sean Liao <sean@liao.dev>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    ccmtaylor authored and seankhliao committed Apr 30, 2025
    Configuration menu
    Copy the full SHA
    cf14319 View commit details
    Browse the repository at this point in the history
Loading