Skip to content

Conversation

@julienschmidt
Copy link
Member

Description

  • added a test environment using a docker container with MySQL 8.0
  • set local-infile=1 via command args (defaults to 0 in MySQL 8)
  • changed the wait script to grep the output, since the mysql client does not support all the required auth plugins (such as MySQL 8.0's default auth plugin).
  • removed the sleep command and poll the status more aggressively instead, potentially reducing the wait time

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4.0 milestone May 20, 2018
@julienschmidt julienschmidt requested a review from methane May 20, 2018 11:34
@julienschmidt julienschmidt merged commit d03e4c2 into master May 21, 2018
@julienschmidt julienschmidt deleted the travis-mysql8 branch May 21, 2018 09:13
@arvenil
Copy link
Contributor

arvenil commented May 21, 2018

@julienschmidt A suggestion. Don't use mysql client from travis host. Use the one in docker image. This way mysql client 8 will talk to mysql server 8 and you won't need any additional hacks.
https://github.com/percona/qan-agent/blob/master/.travis.yml#L73

docker-compose exec mysql mysql -e 'SELECT 1'

@julienschmidt
Copy link
Member Author

Thanks for the hint! Do you mind sending a pull request?

@arvenil
Copy link
Contributor

arvenil commented May 21, 2018

I can do it later, right now fighting with MySQL 8 support ;)

@julienschmidt julienschmidt mentioned this pull request May 17, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants