Skip to content

args assigned and not used #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julienschmidt merged 2 commits into from
Apr 28, 2017
Merged

args assigned and not used #575

julienschmidt merged 2 commits into from
Apr 28, 2017

Conversation

@astaxie
Copy link
Contributor

@astaxie astaxie commented Apr 28, 2017 •
edited
Loading

Description

Use ineffassign to check the code and find

github.com/go-sql-driver/mysql/connection.go:275:3: args assigned and not used
github.com/go-sql-driver/mysql/connection.go:333:3: args assigned and not used

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt
Copy link
Member

julienschmidt commented Apr 28, 2017

Please make an entry to the AUTHORS file so we can merge the PR.

julienschmidt
julienschmidt approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@julienschmidt julienschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will merge as soon as the CI check let's us

@julienschmidt julienschmidt merged commit 147bd02 into go-sql-driver:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astaxie @julienschmidt @methane