Don't link in libpython / libpypy

Author: asottile

setuptools_golang.py

@@ -2,7 +2,6 @@
 from __future__ import unicode_literals
 
 import contextlib
-import distutils.sysconfig
 import os
 import pipes
 import shutil
@@ -13,49 +12,10 @@
 from setuptools.command.build_ext import build_ext as _build_ext
 
 
-PYPY = '__pypy__' in sys.builtin_module_names
-
-
 def _get_cflags(compiler):
     return ' '.join('-I{}'.format(p) for p in compiler.include_dirs)
 
 
-def _get_ldflags_pypy():
-    if PYPY:  # pragma: no cover (pypy only)
-        return '-L{} -lpypy-c'.format(
-            os.path.dirname(os.path.realpath(sys.executable)),
-        )
-    else:
-        return None
-
-
-def _get_ldflags_pkg_config():
-    try:
-        return subprocess.check_output((
-            'pkg-config', '--libs',
-            'python-{}.{}'.format(*sys.version_info[:2]),
-        )).decode('UTF-8').strip()
-    except (subprocess.CalledProcessError, OSError):
-        return None
-
-
-def _get_ldflags_bldlibrary():
-    return distutils.sysconfig.get_config_var('BLDLIBRARY')
-
-
-def _get_ldflags():
-    for func in (
-            _get_ldflags_pypy,
-            _get_ldflags_pkg_config,
-            _get_ldflags_bldlibrary,
-    ):
-        ret = func()
-        if ret is not None:
-            return ret
-    else:
-        raise AssertionError('Could not determine ldflags!')
-
-
 def _check_call(cmd, cwd, env):
     envparts = [
         '{}={}'.format(k, pipes.quote(v))
@@ -113,7 +73,7 @@ def _raise_error(msg):
 
             env.update({
                 'CGO_CFLAGS': _get_cflags(self.compiler),
-                'CGO_LDFLAGS': _get_ldflags(),
+                'CGO_LDFLAGS': '-Wl,--unresolved-symbols=ignore-all',
             })
             cmd_build = (
                 'go', 'build', '-buildmode=c-shared',

setuptools_golang_test.py

@@ -11,11 +11,6 @@
 import setuptools_golang
 
 
-xfailif_pypy = pytest.mark.xfail(
-    setuptools_golang.PYPY, reason='pypy is a special snowflake',
-)
-
-
 @pytest.fixture(autouse=True, scope='session')
 def enable_coverage_subprocesses():
     here = os.path.dirname(os.path.abspath(__file__))
@@ -56,30 +51,6 @@ def test_sets_cmdclass():
     assert dist.cmdclass['build_ext']
 
 
-GET_LDFLAGS = (
-    'import distutils.spawn;'
-    "print(bool(distutils.spawn.find_executable('pkg-config')));"
-    'import setuptools_golang;'
-    'print(setuptools_golang._get_ldflags());'
-)
-
-
-@xfailif_pypy
-def test_from_pkg_config():
-    output = run_output(sys.executable, '-c', GET_LDFLAGS)
-    assert output.startswith('True\n')
-    assert '-lpython' in output
-
-
-@xfailif_pypy
-def test_no_pkg_config():
-    # Blank PATH so we don't have pkg-config
-    env = dict(os.environ, PATH='')
-    output = run_output(sys.executable, '-c', GET_LDFLAGS, env=env)
-    assert output.startswith('False\n')
-    assert '-lpython' in output
-
-
 @pytest.yield_fixture(scope='session')
 def venv(tmpdir_factory):
     """A shared virtualenv fixture, be careful not to install two of the same

tox.ini

@@ -15,17 +15,6 @@ commands =
     pre-commit install -f --install-hooks
     pre-commit run --all-files
 
-[testenv:pypy]
-deps = {[testenv]deps}
-passenv = {[testenv]passenv}
-setenv = {[testenv]setenv}
-commands =
-    coverage erase
-    coverage run -m pytest {posargs:setuptools_golang_test.py}
-    coverage combine
-    # Omit --fail-under for pypy
-    coverage report --show-missing
-
 [testenv:venv]
 envdir = venv-{[tox]project}
 commands =