compile,py: fix closure and decorator #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 74.52% 74.81% +0.29%
==========================================
Files 78 78
Lines 12804 12814 +10
==========================================
+ Hits 9542 9587 +45
+ Misses 2583 2553 -30
+ Partials 679 674 -5
☔ View full report in Codecov by Sentry. |
sbinet
reviewed
Oct 12, 2023
Contributor
Author
|
PTAL, fixed an issue with compiler closures, and added test cases for decorators |
wetor
changed the title
Contributor
Author
|
please skip the Codecov that did not pass, as this part of the code has not been covered |
wetor
commented
Oct 13, 2023
sbinet
reviewed
Oct 16, 2023
Member
|
(otherwise LGTM, thanks.) |
sbinet
approved these changes
Oct 17, 2023
Member
sbinet
left a comment
sbinet
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several hours of reading the Python source code, it was found that the closure issue was only caused by the lack of assignment to
Code.Cell2argThe submission still requires some optimization, and I will complete it in the near future. If possible, I would also like to receive some coding suggestions