Fix errors spotted by go vet

Author: ncw

compile/compile.go

@@ -413,7 +413,7 @@ func (c *compiler) getRefType(name string) symtable.Scope {
 	}
 	scope := c.SymTable.GetScope(name)
 	if scope == symtable.ScopeInvalid {
-		panic(fmt.Sprintf("compile: getRefType: unknown scope for %s in %s\nsymbols: %s\nlocals: %s\nglobals: %s", name, c.Code.Name, c.SymTable.Symbols, c.Code.Varnames, c.Code.Names))
+		panic(fmt.Sprintf("compile: getRefType: unknown scope for %s in %s\nsymbols: %v\nlocals: %s\nglobals: %s", name, c.Code.Name, c.SymTable.Symbols, c.Code.Varnames, c.Code.Names))
 	}
 	return scope
 }

main.go

@@ -78,18 +78,18 @@ func main() {
 	// FIXME should be using ImportModuleLevelObject() here
 	f, err := os.Open(prog)
 	if err != nil {
-		log.Fatal("Failed to open %q: %v", prog, err)
+		log.Fatalf("Failed to open %q: %v", prog, err)
 	}
 	var obj py.Object
 	if strings.HasSuffix(prog, ".pyc") {
 		obj, err = marshal.ReadPyc(f)
 		if err != nil {
-			log.Fatal("Failed to marshal %q: %v", prog, err)
+			log.Fatalf("Failed to marshal %q: %v", prog, err)
 		}
 	} else if strings.HasSuffix(prog, ".py") {
 		str, err := ioutil.ReadAll(f)
 		if err != nil {
-			log.Fatal("Failed to read %q: %v", prog, err)
+			log.Fatalf("Failed to read %q: %v", prog, err)
 		}
 		obj, err = compile.Compile(string(str), prog, "exec", 0, true)
 		if err != nil {

marshal/marshal.go

@@ -325,7 +325,7 @@ func (rfile *rFile) ReadObject() (obj py.Object, err error) {
 			fmt.Printf("Returning None as %d/%d out of range\n", n, len(rfile.refs))
 			return py.None, nil
 
-			return nil, fmt.Errorf("TYPE_REF (out of range) - %d vs %d: %#v", n, len(rfile.refs), rfile.refs)
+			// return nil, fmt.Errorf("TYPE_REF (out of range) - %d vs %d: %#v", n, len(rfile.refs), rfile.refs)
 		}
 		AddRef = false
 		return rfile.refs[n], nil

notes.txt

@@ -7,6 +7,13 @@ Code Quality
 Limitations
 ===========
   * string keys only in dictionaries
+    * intermediate fix - stop it panicing!
+  * line numbers missing in SyntaxErrors
+  * \N{...} escapes not implemented
+  * Interactive interpreter does single lines only
+  * compile(..., "single") not working
+  * string[x] wrong for unicode strings (easy fix)
+  * lots of builtins still to implement
 
 Todo
 ====